git
/
linux
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rust: bitmap: clean Rust 1.92.0 `unused_unsafe` warning 

Starting with Rust 1.92.0 (expected 2025-12-11), Rust allows to safely
take the address of a union field [1][2]:

      CLIPPY L rust/kernel.o
    error: unnecessary `unsafe` block
       --> rust/kernel/bitmap.rs:169:13
        |
    169 |             unsafe { core::ptr::addr_of!(self.repr.bitmap) }
        |             ^^^^^^ unnecessary `unsafe` block
        |
        = note: `-D unused-unsafe` implied by `-D warnings`
        = help: to override `-D warnings` add `#[allow(unused_unsafe)]`

    error: unnecessary `unsafe` block
       --> rust/kernel/bitmap.rs:185:13
        |
    185 |             unsafe { core::ptr::addr_of_mut!(self.repr.bitmap) }
        |             ^^^^^^ unnecessary `unsafe` block

Thus allow both instances to clean the warning in newer compilers.

Link: https://github.com/rust-lang/rust/issues/141264 [1]
Link: https://github.com/rust-lang/rust/pull/141469 [2]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
This commit is contained in:
Miguel Ojeda 2025-10-13 02:14:22 +02:00 committed by Yury Norov (NVIDIA)
parent 9b332cece9
commit 0f5878834d
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rust/kernel/bitmap.rs
View File

@ -166,6 +166,7 @@ impl core::ops::Deref for BitmapVec {
fn deref(&self) -> &Bitmap { fn deref(&self) -> &Bitmap {
let ptr = if self.nbits <= BITS_PER_LONG { let ptr = if self.nbits <= BITS_PER_LONG {
// SAFETY: Bitmap is represented inline. // SAFETY: Bitmap is represented inline.
#[allow(unused_unsafe, reason = "Safe since Rust 1.92.0")]
unsafe { core::ptr::addr_of!(self.repr.bitmap) } unsafe { core::ptr::addr_of!(self.repr.bitmap) }
} else { } else {
// SAFETY: Bitmap is represented as array of `unsigned long`. // SAFETY: Bitmap is represented as array of `unsigned long`.
@ -182,6 +183,7 @@ impl core::ops::DerefMut for BitmapVec {
fn deref_mut(&mut self) -> &mut Bitmap { fn deref_mut(&mut self) -> &mut Bitmap {
let ptr = if self.nbits <= BITS_PER_LONG { let ptr = if self.nbits <= BITS_PER_LONG {
// SAFETY: Bitmap is represented inline. // SAFETY: Bitmap is represented inline.
#[allow(unused_unsafe, reason = "Safe since Rust 1.92.0")]
unsafe { core::ptr::addr_of_mut!(self.repr.bitmap) } unsafe { core::ptr::addr_of_mut!(self.repr.bitmap) }
} else { } else {
// SAFETY: Bitmap is represented as array of `unsigned long`. // SAFETY: Bitmap is represented as array of `unsigned long`.