git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

re PR rtl-optimization/70007 (wrong code with -mbmi2) 

PR rtl-optimization/70007
	* gcse.c (compute_ld_motion_mems): Tidy up and also invalidate memory
	references present in REG_EQUAL notes attached to non-SET patterns.

From-SVN: r233867
This commit is contained in:
Eric Botcazou 2016-03-01 22:31:52 +00:00 committed by Eric Botcazou
parent 2a9afc8680
commit 0bca04b822
4 changed files with 56 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2016-03-01 Eric Botcazou <ebotcazou@adacore.com>
PR rtl-optimization/70007
* gcse.c (compute_ld_motion_mems): Tidy up and also invalidate memory
references present in REG_EQUAL notes attached to non-SET patterns.
2016-03-01 Jeff Law <law@redhat.com> 2016-03-01 Jeff Law <law@redhat.com>
PR tree-optimization/69196 PR tree-optimization/69196

27
gcc/gcse.c
View File

@ -3796,10 +3796,8 @@ compute_ld_motion_mems (void)
{ {
rtx src = SET_SRC (PATTERN (insn)); rtx src = SET_SRC (PATTERN (insn));
rtx dest = SET_DEST (PATTERN (insn)); rtx dest = SET_DEST (PATTERN (insn));
rtx note = find_reg_equal_equiv_note (insn);
rtx src_eq;
/* Check for a simple LOAD... */ /* Check for a simple load. */
if (MEM_P (src) && simple_mem (src)) if (MEM_P (src) && simple_mem (src))
{ {
ptr = ldst_entry (src); ptr = ldst_entry (src);
@ -3814,12 +3812,11 @@ compute_ld_motion_mems (void)
invalidate_any_buried_refs (src); invalidate_any_buried_refs (src);
} }
if (note != 0 && REG_NOTE_KIND (note) == REG_EQUAL) /* Check for a simple load through a REG_EQUAL note. */
src_eq = XEXP (note, 0); rtx note = find_reg_equal_equiv_note (insn), src_eq;
else if (note
src_eq = NULL_RTX; && REG_NOTE_KIND (note) == REG_EQUAL
&& (src_eq = XEXP (note, 0))
if (src_eq != NULL_RTX
&& !(MEM_P (src_eq) && simple_mem (src_eq))) && !(MEM_P (src_eq) && simple_mem (src_eq)))
invalidate_any_buried_refs (src_eq); invalidate_any_buried_refs (src_eq);
@ -3843,7 +3840,17 @@ compute_ld_motion_mems (void)
} }
} }
else else
invalidate_any_buried_refs (PATTERN (insn)); {
/* Invalidate all MEMs in the pattern and... */
invalidate_any_buried_refs (PATTERN (insn));
/* ...in REG_EQUAL notes for PARALLELs with single SET. */
rtx note = find_reg_equal_equiv_note (insn), src_eq;
if (note
&& REG_NOTE_KIND (note) == REG_EQUAL
&& (src_eq = XEXP (note, 0)))
invalidate_any_buried_refs (src_eq);
}
} }
} }
} }

4
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2016-03-01 Eric Botcazou <ebotcazou@adacore.com>
* gcc.target/i386/pr70007.c: New test.
2016-03-01 Jeff Law <law@redhat.com> 2016-03-01 Jeff Law <law@redhat.com>
PR tree-optimization/69196 PR tree-optimization/69196

29
gcc/testsuite/gcc.target/i386/pr70007.c Normal file
View File

@ -0,0 +1,29 @@
/* PR rtl-optimization/70007 */
/* { dg-do run } */
/* { dg-options "-O -fgcse -mbmi2" } */
/* { dg-require-effective-target bmi2 } */
typedef unsigned short v32u16 __attribute__ ((vector_size (32)));
typedef unsigned long long v32u64 __attribute__ ((vector_size (32)));
typedef unsigned __int128 u128;
typedef unsigned __int128 v32u128 __attribute__ ((vector_size (32)));
u128
foo (v32u16 v32u16_0, v32u64 v32u64_0, v32u64 v32u64_1)
{
do {
v32u16_0[13] |= v32u64_1[3] = (v32u64_1[3] >> 19) | (v32u64_1[3] << 45);
v32u64_1 %= ~v32u64_1;
v32u64_0 *= (v32u64) v32u16_0;
} while (v32u64_0[0]);
return v32u64_1[3];
}
int
main (void)
{
u128 x = foo((v32u16){~0xba31, 0x47c6}, (v32u64){64}, (v32u64){0, 0x8b217e2514d23242, 0xac569b6dff9f82, 0x9d4cffe03c139c});
if (x != 0x3c74da5ca328d09)
__builtin_abort();
return 0;
}