git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

match: Fix `(a == b) | ((a|b) != 0)` pattern for vectors [PR122296] 

The pattern `(a == b) | ((a|b) != 0)` uses build_one_cst to build boolean true
but boolean can be a signed multi-bit type. So this changes the result to
use constant_boolean_node isntead.
`(a != b) & ((a|b) == 0)` has a similar issue but in that case it is less likely
to be an issue as false is almost always just 0 but this changes it to be consistent.

Pushed as obvious after a bootstrap/test on x86_64-linux-gnu.

	PR tree-optimization/122296

gcc/ChangeLog:

	* match.pd (`(a == b) | ((a|b) != 0)`): Fix true value.

gcc/testsuite/ChangeLog:

	* gcc.dg/tree-ssa/int-bwise-opt-vect01.c: New test.

Signed-off-by: Andrew Pinski <andrew.pinski@oss.qualcomm.com>
This commit is contained in:
Andrew Pinski 2025-10-16 16:10:59 -07:00
parent 175bacbb25
commit 128933c9cf
2 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gcc/match.pd
View File

@ -6854,10 +6854,10 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
(eq @0 @1)) (eq @0 @1))
(simplify (simplify
(bit_and:c (ne:c @0 @1) (eq (bit_ior @0 @1) integer_zerop)) (bit_and:c (ne:c @0 @1) (eq (bit_ior @0 @1) integer_zerop))
{ build_zero_cst (type); }) { constant_boolean_node (false, type); })
(simplify (simplify
(bit_ior:c (eq:c @0 @1) (ne (bit_ior @0 @1) integer_zerop)) (bit_ior:c (eq:c @0 @1) (ne (bit_ior @0 @1) integer_zerop))
{ build_one_cst (type); }) { constant_boolean_node (true, type); })
#endif #endif
/* These was part of minmax phiopt. */ /* These was part of minmax phiopt. */

17
gcc/testsuite/gcc.dg/tree-ssa/int-bwise-opt-vect01.c Normal file
View File

@ -0,0 +1,17 @@
/* { dg-do compile } */
/* { dg-options "-O1 -fdump-tree-forwprop1 -fdump-tree-optimized" } */
/* PR tree-optimization/122296 */
typedef unsigned type1 __attribute__((vector_size(sizeof(unsigned))));
type1 f(type1 a, type1 b)
{
type1 c = a == b;
type1 d = (a|b) != 0;
return c | d;
}
/* { dg-final { scan-tree-dump-not "VEC_COND_EXPR " "optimized" } } */
/* { dg-final { scan-tree-dump-not "VEC_COND_EXPR " "forwprop1" } } */