git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

re PR c++/51930 (Explicitly instantiated template gets hidden visibility) 

PR c++/51930
	* decl2.c (determine_visibility): Check for visibility attribute
	on template specialization.

From-SVN: r183455
This commit is contained in:
Jason Merrill 2012-01-23 15:48:31 -05:00 committed by Jason Merrill
parent c5a3e2ecbf
commit 22197246e3
4 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2012-01-23 Jason Merrill <jason@redhat.com>
PR c++/51930
* decl2.c (determine_visibility): Check for visibility attribute
on template specialization.
2012-01-23 Paolo Carlini <paolo.carlini@oracle.com> 2012-01-23 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/51398 PR c++/51398

8
gcc/cp/decl2.c
View File

@ -2177,8 +2177,14 @@ determine_visibility (tree decl)
? TYPE_TEMPLATE_INFO (TREE_TYPE (decl)) ? TYPE_TEMPLATE_INFO (TREE_TYPE (decl))
: DECL_TEMPLATE_INFO (decl)); : DECL_TEMPLATE_INFO (decl));
tree args = TI_ARGS (tinfo); tree args = TI_ARGS (tinfo);
tree attribs = (TREE_CODE (decl) == TYPE_DECL
? TYPE_ATTRIBUTES (TREE_TYPE (decl))
: DECL_ATTRIBUTES (decl));
if (args != error_mark_node) if (args != error_mark_node
/* Template argument visibility outweighs #pragma or namespace
visibility, but not an explicit attribute. */
&& !lookup_attribute ("visibility", attribs))
{ {
int depth = TMPL_ARGS_DEPTH (args); int depth = TMPL_ARGS_DEPTH (args);
tree pattern = DECL_TEMPLATE_RESULT (TI_TEMPLATE (tinfo)); tree pattern = DECL_TEMPLATE_RESULT (TI_TEMPLATE (tinfo));

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2012-01-23 Jason Merrill <jason@redhat.com>
PR c++/51930
* g++.dg/ext/visibility/template10.C: New.
2012-01-23 Tobias Burnus <burnus@net-b.de> 2012-01-23 Tobias Burnus <burnus@net-b.de>
PR fortran/51948 PR fortran/51948

16
gcc/testsuite/g++.dg/ext/visibility/template10.C Normal file
View File

@ -0,0 +1,16 @@
// PR c++/51930
// { dg-require-visibility }
// { dg-options -fvisibility=hidden }
// { dg-final { scan-not-hidden "_Z8testfuncI3fooEvv" } }
struct foo { };
template<typename T>
__attribute__ ((visibility("default")))
void testfunc();
template<typename T> void testfunc() { }
template
__attribute__ ((visibility("default")))
void testfunc<foo>();