git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

libiberty: writeargv: Simplify function error mode. 

You are right, this is also a remnant of the old function design
that I completely missed.    Here is the follow-up patch for that.

Thanks for pointing it out.

Costas

On Tue, 6 Jun 2023 at 04:12, Jeff Law <jeffreyalaw@gmail.com> wrote:

    On 6/5/23 08:37, Costas Argyris via Gcc-patches wrote:
    > writeargv can be simplified by getting rid of the error exit mode
    > that was only relevant many years ago when the function used
    > to open the file descriptor internally.
    [ ... ]
    Thanks.  I've pushed this to the trunk.

    You could (as a follow-up) simplify it even further.  There's no need
    for the status variable as far as I can tell.  You could just have the
    final return be "return 0;" instead of "return status;".

libiberty/
	* argv.c (writeargv): Constant propagate "0" for "status",
	simplifying the code slightly.
This commit is contained in:
Costas Argyris 2023-06-06 20:50:07 -06:00 committed by Jeff Law
parent 64d90d06d2
commit 3fe017ee79
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libiberty/argv.c
View File

@ -299,8 +299,6 @@ non-zero if an error occurred while writing to FILE.
int
writeargv (char * const *argv, FILE *f)
{
int status = 0;
if (f == NULL)
return 1;
@ -333,7 +331,7 @@ writeargv (char * const *argv, FILE *f)
argv++;
}
return status;
return 0;
}
/*