git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PR c/70281: C FE: fix uninitialized range for __builtin_types_compatible_p 

gcc/c/ChangeLog:
	PR c/70281
	* c-parser.c (c_parser_postfix_expression): Set the source range
	for uses of "__builtin_types_compatible_p".

gcc/testsuite/ChangeLog:
	PR c/70281
	* gcc.dg/plugin/diagnostic-test-expressions-1.c
	(test_builtin_types_compatible_p): New test function.
	* gcc.dg/pr70281.c: New test case.

From-SVN: r234340
This commit is contained in:
David Malcolm 2016-03-18 17:45:42 +00:00 committed by David Malcolm
parent f2f48c6c60
commit 4bbf545b8b
5 changed files with 44 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/c/ChangeLog
View File

@ -1,3 +1,9 @@
2016-03-18 David Malcolm <dmalcolm@redhat.com>
PR c/70281
* c-parser.c (c_parser_postfix_expression): Set the source range
for uses of "__builtin_types_compatible_p".
2016-03-17 Jakub Jelinek <jakub@redhat.com> 2016-03-17 Jakub Jelinek <jakub@redhat.com>
PR c/70280 PR c/70280

6
gcc/c/c-parser.c
View File

@ -7782,9 +7782,10 @@ c_parser_postfix_expression (c_parser *parser)
expr.value = error_mark_node; expr.value = error_mark_node;
break; break;
} }
c_parser_skip_until_found (parser, CPP_CLOSE_PAREN,
"expected %<)%>");
{ {
location_t close_paren_loc = c_parser_peek_token (parser)->location;
c_parser_skip_until_found (parser, CPP_CLOSE_PAREN,
"expected %<)%>");
tree e1, e2; tree e1, e2;
e1 = groktypename (t1, NULL, NULL); e1 = groktypename (t1, NULL, NULL);
e2 = groktypename (t2, NULL, NULL); e2 = groktypename (t2, NULL, NULL);
@ -7799,6 +7800,7 @@ c_parser_postfix_expression (c_parser *parser)
expr.value expr.value
= comptypes (e1, e2) ? integer_one_node : integer_zero_node; = comptypes (e1, e2) ? integer_one_node : integer_zero_node;
set_c_expr_source_range (&expr, loc, close_paren_loc);
} }
break; break;
case RID_BUILTIN_CALL_WITH_STATIC_CHAIN: case RID_BUILTIN_CALL_WITH_STATIC_CHAIN:

7
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,10 @@
2016-03-18 David Malcolm <dmalcolm@redhat.com>
PR c/70281
* gcc.dg/plugin/diagnostic-test-expressions-1.c
(test_builtin_types_compatible_p): New test function.
* gcc.dg/pr70281.c: New test case.
2016-03-18 Christophe Lyon <christophe.lyon@linaro.org> 2016-03-18 Christophe Lyon <christophe.lyon@linaro.org>
PR target/70113 PR target/70113

18
gcc/testsuite/gcc.dg/plugin/diagnostic-test-expressions-1.c
View File

@ -534,6 +534,24 @@ void test_builtin_choose_expr (int i)
} }
extern int f (int); extern int f (int);
void test_builtin_types_compatible_p (unsigned long i)
{
__emit_expression_range (0,
f (i) + __builtin_types_compatible_p (long, int)); /* { dg-warning "range" } */
/* { dg-begin-multiline-output "" }
f (i) + __builtin_types_compatible_p (long, int));
~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
{ dg-end-multiline-output "" } */
__emit_expression_range (0,
__builtin_types_compatible_p (long, int) + f (i)); /* { dg-warning "range" } */
/* { dg-begin-multiline-output "" }
__builtin_types_compatible_p (long, int) + f (i));
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
{ dg-end-multiline-output "" } */
}
void test_builtin_call_with_static_chain (int i, void *ptr) void test_builtin_call_with_static_chain (int i, void *ptr)
{ {
__emit_expression_range (0, __builtin_call_with_static_chain (f (i), ptr)); /* { dg-warning "range" } */ __emit_expression_range (0, __builtin_call_with_static_chain (f (i), ptr)); /* { dg-warning "range" } */

9
gcc/testsuite/gcc.dg/pr70281.c Normal file
View File

@ -0,0 +1,9 @@
/* { dg-options "-Wall -fdiagnostics-show-caret" } */
int bch_stats_show ()
{
return __builtin_types_compatible_p (unsigned, int) ? "" : ""; /* { dg-warning "cast" } */
/* { dg-begin-multiline-output "" }
return __builtin_types_compatible_p (unsigned, int) ? "" : "";
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
{ dg-end-multiline-output "" } */
}