git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

In libobjc/: 2010-12-21 Nicola Pero <nicola.pero@meta-innovation.com> 

In libobjc/:
2010-12-21  Nicola Pero  <nicola.pero@meta-innovation.com>

	* hash.c: Tidied up comments and indentation.  No code changes.

From-SVN: r168110
This commit is contained in:
Nicola Pero 2010-12-21 11:24:27 +00:00 committed by Nicola Pero
parent d4d92cd36c
commit 57d75eebe2
2 changed files with 153 additions and 136 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libobjc/ChangeLog
View File

@ -1,3 +1,7 @@
2010-12-21 Nicola Pero <nicola.pero@meta-innovation.com>
* hash.c: Tidied up comments and indentation. No code changes.
2010-12-19 Nicola Pero <nicola.pero@meta-innovation.com>
PR libobjc/47012

151
libobjc/hash.c
View File

@ -23,12 +23,12 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
<http://www.gnu.org/licenses/>. */
#include "objc-private/common.h"
#include <assert.h> /* For assert */
#include <assert.h> /* For assert. */
#include "objc/runtime.h" /* For objc_calloc */
#include "objc/runtime.h" /* For objc_calloc. */
#include "objc/thr.h" /* Required by objc-private/runtime.h. */
#include "objc-private/hash.h"
#include "objc-private/runtime.h" /* for DEBUG_PRINTF */
#include "objc-private/runtime.h" /* for DEBUG_PRINTF. */
/* These two macros determine when a hash table is full and
by how much it should be expanded respectively.
@ -49,27 +49,27 @@ objc_hash_new (unsigned int size, hash_func_type hash_func,
assert (size);
assert (! (size & (size - 1)));
/* Allocate the cache structure. calloc insures
its initialization for default values. */
/* Allocate the cache structure. calloc insures its initialization
for default values. */
cache = (cache_ptr) objc_calloc (1, sizeof (struct cache));
assert (cache);
/* Allocate the array of buckets for the cache.
calloc initializes all of the pointers to NULL. */
/* Allocate the array of buckets for the cache. calloc initializes
all of the pointers to NULL. */
cache->node_table
= (node_ptr *) objc_calloc (size, sizeof (node_ptr));
assert (cache->node_table);
cache->size = size;
/* This should work for all processor architectures? */
/* This should work for all processor architectures (?). */
cache->mask = (size - 1);
/* Store the hashing function so that codes can be computed. */
cache->hash_func = hash_func;
/* Store the function that compares hash keys to
determine if they are equal. */
/* Store the function that compares hash keys to determine if they
are equal. */
cache->compare_func = compare_func;
return cache;
@ -85,16 +85,19 @@ objc_hash_delete (cache_ptr cache)
/* Purge all key/value pairs from the table. */
/* Step through the nodes one by one and remove every node WITHOUT
using objc_hash_next. this makes objc_hash_delete much more efficient. */
for (i = 0;i < cache->size;i++) {
if ((node = cache->node_table[i])) {
/* an entry in the hash table has been found, now step through the
nodes next in the list and free them. */
while ((next_node = node->next)) {
using objc_hash_next. this makes objc_hash_delete much more
efficient. */
for (i = 0; i < cache->size; i++)
{
if ((node = cache->node_table[i]))
{
/* An entry in the hash table has been found. Now step
through the nodes next in the list and free them. */
while ((next_node = node->next))
{
objc_hash_remove (cache,node->key);
node = next_node;
}
objc_hash_remove (cache,node->key);
}
}
@ -111,7 +114,6 @@ objc_hash_add (cache_ptr *cachep, const void *key, void *value)
size_t indx = (*(*cachep)->hash_func) (*cachep, key);
node_ptr node = (node_ptr) objc_calloc (1, sizeof (struct cache_node));
assert (node);
/* Initialize the new node. */
@ -119,13 +121,12 @@ objc_hash_add (cache_ptr *cachep, const void *key, void *value)
node->value = value;
node->next = (*cachep)->node_table[indx];
/* Debugging.
Check the list for another key. */
/* Debugging. Check the list for another key. */
#ifdef DEBUG
{ node_ptr node1 = (*cachep)->node_table[indx];
while (node1) {
{
node_ptr node1 = (*cachep)->node_table[indx];
while (node1)
{
assert (node1->key != key);
node1 = node1->next;
}
@ -138,16 +139,15 @@ objc_hash_add (cache_ptr *cachep, const void *key, void *value)
/* Bump the number of entries in the cache. */
++(*cachep)->used;
/* Check the hash table's fullness. We're going
to expand if it is above the fullness level. */
if (FULLNESS (*cachep)) {
/* Check the hash table's fullness. We're going to expand if it is
above the fullness level. */
if (FULLNESS (*cachep))
{
/* The hash table has reached its fullness level. Time to
expand it.
I'm using a slow method here but is built on other
primitive functions thereby increasing its
correctness. */
I'm using a slow method here but is built on other primitive
functions thereby increasing its correctness. */
node_ptr node1 = NULL;
cache_ptr new = objc_hash_new (EXPANSION (*cachep),
(*cachep)->hash_func,
@ -168,35 +168,39 @@ objc_hash_add (cache_ptr *cachep, const void *key, void *value)
}
}
void
objc_hash_remove (cache_ptr cache, const void *key)
{
size_t indx = (*cache->hash_func) (cache, key);
node_ptr node = cache->node_table[indx];
/* We assume there is an entry in the table. Error if it is not. */
/* We assume there is an entry in the table. Error if it is
not. */
assert (node);
/* Special case. First element is the key/value pair to be removed. */
if ((*cache->compare_func)(node->key, key)) {
/* Special case. First element is the key/value pair to be
removed. */
if ((*cache->compare_func) (node->key, key))
{
cache->node_table[indx] = node->next;
objc_free(node);
} else {
}
else
{
/* Otherwise, find the hash entry. */
node_ptr prev = node;
BOOL removed = NO;
do {
if ((*cache->compare_func)(node->key, key)) {
do
{
if ((*cache->compare_func) (node->key, key))
{
prev->next = node->next, removed = YES;
objc_free(node);
} else
}
else
prev = node, node = node->next;
} while (! removed && node);
}
while (!removed && node);
assert (removed);
}
@ -208,27 +212,31 @@ objc_hash_remove (cache_ptr cache, const void *key)
node_ptr
objc_hash_next (cache_ptr cache, node_ptr node)
{
/* If the scan is being started then reset the last node
visitied pointer and bucket index. */
/* If the scan is being started then reset the last node visitied
pointer and bucket index. */
if (!node)
cache->last_bucket = 0;
/* If there is a node visited last then check for another
entry in the same bucket; Otherwise step to the next bucket. */
if (node) {
/* If there is a node visited last then check for another entry in
the same bucket. Otherwise step to the next bucket. */
if (node)
{
if (node->next)
/* There is a node which follows the last node
returned. Step to that node and retun it. */
{
/* There is a node which follows the last node returned.
Step to that node and retun it. */
return node->next;
}
else
++cache->last_bucket;
}
/* If the list isn't exhausted then search the buckets for
other nodes. */
if (cache->last_bucket < cache->size) {
/* Scan the remainder of the buckets looking for an entry
at the head of the list. Return the first item found. */
/* If the list isn't exhausted then search the buckets for other
nodes. */
if (cache->last_bucket < cache->size)
{
/* Scan the remainder of the buckets looking for an entry at
the head of the list. Return the first item found. */
while (cache->last_bucket < cache->size)
if (cache->node_table[cache->last_bucket])
return cache->node_table[cache->last_bucket];
@ -237,14 +245,14 @@ objc_hash_next (cache_ptr cache, node_ptr node)
/* No further nodes were found in the hash table. */
return NULL;
} else
}
else
return NULL;
}
/* Given KEY, return corresponding value for it in CACHE.
Return NULL if the KEY is not recorded. */
/* Given KEY, return corresponding value for it in CACHE. Return NULL
if the KEY is not recorded. */
void *
objc_hash_value_for_key (cache_ptr cache, const void *key)
{
@ -252,32 +260,37 @@ objc_hash_value_for_key (cache_ptr cache, const void *key)
void *retval = NULL;
if (node)
do {
if ((*cache->compare_func)(node->key, key)) {
do
{
if ((*cache->compare_func) (node->key, key))
{
retval = node->value;
break;
} else
}
else
node = node->next;
} while (! retval && node);
}
while (! retval && node);
return retval;
}
/* Given KEY, return YES if it exists in the CACHE.
Return NO if it does not */
/* Given KEY, return YES if it exists in the CACHE. Return NO if it
does not */
BOOL
objc_hash_is_key_in_hash (cache_ptr cache, const void *key)
{
node_ptr node = cache->node_table[(*cache->hash_func) (cache, key)];
if (node)
do {
do
{
if ((*cache->compare_func)(node->key, key))
return YES;
else
node = node->next;
} while (node);
}
while (node);
return NO;
}