git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

elf.c (elf_add): Close descriptor if we use a debugfile. 

* elf.c (elf_add): Close descriptor if we use a debugfile.
	* btest.c (check_open_files): New static function.
	(main): Call check_open_files.

From-SVN: r257275
This commit is contained in:
Ian Lance Taylor 2018-01-31 23:23:21 +00:00 committed by Ian Lance Taylor
parent bcbe891cd6
commit 65d0b85990
3 changed files with 46 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libbacktrace/ChangeLog
View File

@ -1,3 +1,9 @@
2018-01-31 Ian Lance Taylor <iant@golang.org>
* elf.c (elf_add): Close descriptor if we use a debugfile.
* btest.c (check_open_files): New static function.
(main): Call check_open_files.
2018-01-25 Ian Lance Taylor <iant@golang.org> 2018-01-25 Ian Lance Taylor <iant@golang.org>
* elf.c (elf_open_debugfile_by_debuglink): Don't check CRC if the * elf.c (elf_open_debugfile_by_debuglink): Don't check CRC if the

22
libbacktrace/btest.c
View File

@ -37,6 +37,7 @@ POSSIBILITY OF SUCH DAMAGE. */
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <unistd.h>
#include "filenames.h" #include "filenames.h"
@ -456,6 +457,25 @@ test5 (void)
return failures; return failures;
} }
/* Check that are no files left open. */
static void
check_open_files (void)
{
int i;
for (i = 3; i < 10; i++)
{
if (close (i) == 0)
{
fprintf (stderr,
"ERROR: descriptor %d still open after tests complete\n",
i);
++failures;
}
}
}
/* Run all the tests. */ /* Run all the tests. */
int int
@ -474,5 +494,7 @@ main (int argc ATTRIBUTE_UNUSED, char **argv)
#endif #endif
#endif #endif
check_open_files ();
exit (failures ? EXIT_FAILURE : EXIT_SUCCESS); exit (failures ? EXIT_FAILURE : EXIT_SUCCESS);
} }

18
libbacktrace/elf.c
View File

@ -2929,12 +2929,19 @@ elf_add (struct backtrace_state *state, const char *filename, int descriptor,
error_callback, data); error_callback, data);
if (d >= 0) if (d >= 0)
{ {
int ret;
backtrace_release_view (state, &buildid_view, error_callback, data); backtrace_release_view (state, &buildid_view, error_callback, data);
if (debuglink_view_valid) if (debuglink_view_valid)
backtrace_release_view (state, &debuglink_view, error_callback, backtrace_release_view (state, &debuglink_view, error_callback,
data); data);
return elf_add (state, NULL, d, base_address, error_callback, data, ret = elf_add (state, NULL, d, base_address, error_callback, data,
fileline_fn, found_sym, found_dwarf, 0, 1); fileline_fn, found_sym, found_dwarf, 0, 1);
if (ret < 0)
backtrace_close (d, error_callback, data);
else
backtrace_close (descriptor, error_callback, data);
return ret;
} }
} }
@ -2953,10 +2960,17 @@ elf_add (struct backtrace_state *state, const char *filename, int descriptor,
data); data);
if (d >= 0) if (d >= 0)
{ {
int ret;
backtrace_release_view (state, &debuglink_view, error_callback, backtrace_release_view (state, &debuglink_view, error_callback,
data); data);
return elf_add (state, NULL, d, base_address, error_callback, data, ret = elf_add (state, NULL, d, base_address, error_callback, data,
fileline_fn, found_sym, found_dwarf, 0, 1); fileline_fn, found_sym, found_dwarf, 0, 1);
if (ret < 0)
backtrace_close (d, error_callback, data);
else
backtrace_close(descriptor, error_callback, data);
return ret;
} }
} }