git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

re PR ipa/63569 (Wrong code with volatile and ICF) 

Fix for PR ipa/63569.

	PR ipa/63569
	* gcc.dg/ipa/pr63569.c: New test.
	PR ipa/63569
	* ipa-icf-gimple.c (func_checker::compare_operand): Add missing
	comparison for volatile flag.

From-SVN: r218949
This commit is contained in:
Martin Liska 2014-12-19 13:40:50 +01:00 committed by Martin Liska
parent 1f8d3e84ee
commit 6b0e0695a5
4 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2014-12-19 Martin Liska <mliska@suse.cz>
PR ipa/63569
* ipa-icf-gimple.c (func_checker::compare_operand): Add missing
comparison for volatile flag.
2014-12-19 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
* doc/invoke.texi (ARM options): Remove mention of Advanced RISC

3
gcc/ipa-icf-gimple.c
View File

@ -230,6 +230,9 @@ func_checker::compare_operand (tree t1, tree t2)
tree tt1 = TREE_TYPE (t1);
tree tt2 = TREE_TYPE (t2);
if (TREE_THIS_VOLATILE (t1) != TREE_THIS_VOLATILE (t2))
return return_false_with_msg ("different operand volatility");
if (!func_checker::compatible_types_p (tt1, tt2))
return false;

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2014-12-19 Martin Liska <mliska@suse.cz>
PR ipa/63569
* gcc.dg/ipa/pr63569.c: New test.
2014-12-19 Jakub Jelinek <jakub@redhat.com>
PR preprocessor/63831

32
gcc/testsuite/gcc.dg/ipa/pr63569.c Normal file
View File

@ -0,0 +1,32 @@
/* { dg-do compile } */
/* { dg-options "-O2 -fdump-ipa-icf-details" } */
static int f(int t, int *a) __attribute__((noinline));
static int g(int t, volatile int *a) __attribute__((noinline));
static int g(int t, volatile int *a)
{
int i;
int tt = 0;
for(i=0;i<t;i++)
tt += *a;
return tt;
}
static int f(int t, int *a)
{
int i;
int tt = 0;
for(i=0;i<t;i++)
tt += *a;
return tt;
}
int h(int t, int *a)
{
return f(t, a) + g(t, a);
}
/* { dg-final { scan-ipa-dump "different operand volatility" "icf" } } */
/* { dg-final { scan-ipa-dump "Equal symbols: 0" "icf" } } */
/* { dg-final { cleanup-ipa-dump "icf" } } */