git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

re PR c++/44859 (missed warning: returning reference to temporary) 

PR c++/44859
	* typeck.c (maybe_warn_about_returning_address_of_local): Unwrap
	COMPONENT_REFs and ARRAY_REFs sooner.

From-SVN: r208970
This commit is contained in:
Patrick Palka 2014-03-31 20:48:33 -04:00 committed by Jason Merrill
parent 3020dc6e31
commit 75d850f368
3 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2014-03-31 Patrick Palka patrick@parcs.ath.cx
PR c++/44859
* typeck.c (maybe_warn_about_returning_address_of_local): Unwrap
COMPONENT_REFs and ARRAY_REFs sooner.
2014-03-29 Adam Butcher <adam@jessamine.co.uk> 2014-03-29 Adam Butcher <adam@jessamine.co.uk>
PR c++/60626 PR c++/60626

8
gcc/cp/typeck.c
View File

@ -8283,6 +8283,10 @@ maybe_warn_about_returning_address_of_local (tree retval)
return; return;
whats_returned = TREE_OPERAND (whats_returned, 0); whats_returned = TREE_OPERAND (whats_returned, 0);
while (TREE_CODE (whats_returned) == COMPONENT_REF
|| TREE_CODE (whats_returned) == ARRAY_REF)
whats_returned = TREE_OPERAND (whats_returned, 0);
if (TREE_CODE (valtype) == REFERENCE_TYPE) if (TREE_CODE (valtype) == REFERENCE_TYPE)
{ {
if (TREE_CODE (whats_returned) == AGGR_INIT_EXPR if (TREE_CODE (whats_returned) == AGGR_INIT_EXPR
@ -8300,10 +8304,6 @@ maybe_warn_about_returning_address_of_local (tree retval)
} }
} }
while (TREE_CODE (whats_returned) == COMPONENT_REF
|| TREE_CODE (whats_returned) == ARRAY_REF)
whats_returned = TREE_OPERAND (whats_returned, 0);
if (DECL_P (whats_returned) if (DECL_P (whats_returned)
&& DECL_NAME (whats_returned) && DECL_NAME (whats_returned)
&& DECL_FUNCTION_SCOPE_P (whats_returned) && DECL_FUNCTION_SCOPE_P (whats_returned)

11
gcc/testsuite/g++.dg/warn/Wreturn-local-addr-2.C Normal file
View File

@ -0,0 +1,11 @@
// PR c++/44859
struct Base2 { int m_foo; };
struct Derived2 : public Base2 {};
const Base2& f8() { return Derived2(); } // { dg-warning "reference to temporary" }
struct foo { };
struct bar { foo base; };
const foo& f9() { return bar().base; } // { dg-warning "reference to temporary" }