* c-decl.c (implicit_decl_warning): Add a comment. Fix formatting.

From-SVN: r246069
This commit is contained in:
Marek Polacek 2017-03-11 10:26:35 +00:00 committed by Marek Polacek
parent 2f6f187a86
commit 85059a38cb
2 changed files with 44 additions and 33 deletions

View File

@ -1,3 +1,7 @@
2017-03-11 Marek Polacek <polacek@redhat.com>
* c-decl.c (implicit_decl_warning): Add a comment. Fix formatting.
2017-03-10 David Malcolm <dmalcolm@redhat.com> 2017-03-10 David Malcolm <dmalcolm@redhat.com>
PR translation/79848 PR translation/79848

View File

@ -3117,17 +3117,24 @@ pushdecl_top_level (tree x)
return x; return x;
} }
/* Issue a warning about implicit function declaration. ID is the function
identifier, OLDDECL is a declaration of the function in a different scope,
or NULL_TREE. */
static void static void
implicit_decl_warning (location_t loc, tree id, tree olddecl) implicit_decl_warning (location_t loc, tree id, tree olddecl)
{ {
if (warn_implicit_function_declaration) if (!warn_implicit_function_declaration)
{ return;
bool warned; bool warned;
const char *hint = NULL; const char *hint = NULL;
if (!olddecl) if (!olddecl)
hint = lookup_name_fuzzy (id, FUZZY_LOOKUP_FUNCTION_NAME); hint = lookup_name_fuzzy (id, FUZZY_LOOKUP_FUNCTION_NAME);
if (flag_isoc99) if (flag_isoc99)
{
if (hint) if (hint)
{ {
gcc_rich_location richloc (loc); gcc_rich_location richloc (loc);
@ -3140,8 +3147,8 @@ implicit_decl_warning (location_t loc, tree id, tree olddecl)
else else
warned = pedwarn (loc, OPT_Wimplicit_function_declaration, warned = pedwarn (loc, OPT_Wimplicit_function_declaration,
"implicit declaration of function %qE", id); "implicit declaration of function %qE", id);
else }
if (hint) else if (hint)
{ {
gcc_rich_location richloc (loc); gcc_rich_location richloc (loc);
richloc.add_fixit_replace (hint); richloc.add_fixit_replace (hint);
@ -3153,10 +3160,10 @@ implicit_decl_warning (location_t loc, tree id, tree olddecl)
else else
warned = warning_at (loc, OPT_Wimplicit_function_declaration, warned = warning_at (loc, OPT_Wimplicit_function_declaration,
G_("implicit declaration of function %qE"), id); G_("implicit declaration of function %qE"), id);
if (olddecl && warned) if (olddecl && warned)
locate_old_decl (olddecl); locate_old_decl (olddecl);
} }
}
/* This function represents mapping of a function code FCODE /* This function represents mapping of a function code FCODE
to its respective header. */ to its respective header. */