git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rs6000.c (print_operand): Revise code that unsafely relied on signed overflow behavior. 

2012-05-18  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

	* config/rs6000/rs6000.c (print_operand): Revise code that unsafely
	relied on signed overflow behavior.

From-SVN: r187657
This commit is contained in:
Bill Schmidt 2012-05-18 16:01:17 +00:00 committed by William Schmidt
parent a4293fa661
commit 9c68125ebc
2 changed files with 10 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/ChangeLog
View File

@ -1,3 +1,8 @@
2012-05-18 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
* config/rs6000/rs6000.c (print_operand): Revise code that unsafely
relied on signed overflow behavior.
2012-05-18 Richard Guenther <rguenther@suse.de> 2012-05-18 Richard Guenther <rguenther@suse.de>
PR tree-optimization/53346 PR tree-optimization/53346

28
gcc/config/rs6000/rs6000.c
View File

@ -14679,7 +14679,6 @@ void
print_operand (FILE *file, rtx x, int code) print_operand (FILE *file, rtx x, int code)
{ {
int i; int i;
HOST_WIDE_INT val;
unsigned HOST_WIDE_INT uval; unsigned HOST_WIDE_INT uval;
switch (code) switch (code)
@ -15120,34 +15119,17 @@ print_operand (FILE *file, rtx x, int code)
case 'W': case 'W':
/* MB value for a PowerPC64 rldic operand. */ /* MB value for a PowerPC64 rldic operand. */
val = (GET_CODE (x) == CONST_INT i = clz_hwi (GET_CODE (x) == CONST_INT
? INTVAL (x) : CONST_DOUBLE_HIGH (x)); ? INTVAL (x) : CONST_DOUBLE_HIGH (x));
if (val < 0)
i = -1;
else
for (i = 0; i < HOST_BITS_PER_WIDE_INT; i++)
if ((val <<= 1) < 0)
break;
#if HOST_BITS_PER_WIDE_INT == 32 #if HOST_BITS_PER_WIDE_INT == 32
if (GET_CODE (x) == CONST_INT && i >= 0) if (GET_CODE (x) == CONST_INT && i > 0)
i += 32; /* zero-extend high-part was all 0's */ i += 32; /* zero-extend high-part was all 0's */
else if (GET_CODE (x) == CONST_DOUBLE && i == 32) else if (GET_CODE (x) == CONST_DOUBLE && i == 32)
{ i = clz_hwi (CONST_DOUBLE_LOW (x)) + 32;
val = CONST_DOUBLE_LOW (x);
gcc_assert (val);
if (val < 0)
--i;
else
for ( ; i < 64; i++)
if ((val <<= 1) < 0)
break;
}
#endif #endif
fprintf (file, "%d", i + 1); fprintf (file, "%d", i);
return; return;
case 'x': case 'x':