git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Delete temporary string within demangler even in failure cases. 

A call to demangle_template might allocate storage within a temporary
string even if the call to demangle_template eventually returns
failure.

This will never cause the demangler to crash, but does leak memory, as
a result I've not added any tests for this.

Calling string_delete is safe, even if nothing is allocated into the
string, the string is initialised with string_init, so we know the
internal pointers are NULL.

libiberty/ChangeLog

	* cplus-dem.c (do_type): Call string_delete even if the call to
	demangle_template fails.

From-SVN: r211449
This commit is contained in:
Andrew Burgess 2014-06-11 10:57:27 +00:00 committed by Pedro Alves
parent b785e0b875
commit ac8345a525
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libiberty/ChangeLog
View File

@ -1,3 +1,8 @@
2014-06-11 Andrew Burgess <aburgess@broadcom.com>
* cplus-dem.c (do_type): Call string_delete even if the call to
demangle_template fails.
2014-06-01 Ray Donnelly <mingw.android@gmail.com> 2014-06-01 Ray Donnelly <mingw.android@gmail.com>
* pex-win32.c (argv_to_cmdline): Don't quote * pex-win32.c (argv_to_cmdline): Don't quote

3
libiberty/cplus-dem.c
View File

@ -3663,8 +3663,11 @@ do_type (struct work_stuff *work, const char **mangled, string *result)
string_delete (&temp); string_delete (&temp);
} }
else else
{
string_delete (&temp);
break; break;
} }
}
else if (**mangled == 'Q') else if (**mangled == 'Q')
{ {
success = demangle_qualified (work, mangled, &decl, success = demangle_qualified (work, mangled, &decl,