git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

re PR c/60915 (confusing diagnostic from attribute on function definition) 

PR c/60915
	* c-parser.c (c_parser_declaration_or_fndef): Give better error if
	function-definition has an attribute after the declarator.

	* gcc.dg/pr60915.c: New test.

From-SVN: r209975
This commit is contained in:
Marek Polacek 2014-05-01 07:40:26 +00:00 committed by Marek Polacek
parent 96b40f8d4c
commit ae5ebda473
4 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/c/ChangeLog
View File

@ -1,3 +1,9 @@
2014-05-01 Marek Polacek <polacek@redhat.com>
PR c/60915
* c-parser.c (c_parser_declaration_or_fndef): Give better error if
function-definition has an attribute after the declarator.
2014-05-01 Marek Polacek <polacek@redhat.com> 2014-05-01 Marek Polacek <polacek@redhat.com>
PR c/60257 PR c/60257

14
gcc/c/c-parser.c
View File

@ -1688,7 +1688,19 @@ c_parser_declaration_or_fndef (c_parser *parser, bool fndef_ok,
if (c_parser_next_token_is_keyword (parser, RID_ASM)) if (c_parser_next_token_is_keyword (parser, RID_ASM))
asm_name = c_parser_simple_asm_expr (parser); asm_name = c_parser_simple_asm_expr (parser);
if (c_parser_next_token_is_keyword (parser, RID_ATTRIBUTE)) if (c_parser_next_token_is_keyword (parser, RID_ATTRIBUTE))
postfix_attrs = c_parser_attributes (parser); {
postfix_attrs = c_parser_attributes (parser);
if (c_parser_next_token_is (parser, CPP_OPEN_BRACE))
{
/* This means there is an attribute specifier after
the declarator in a function definition. Provide
some more information for the user. */
error_at (here, "attributes should be specified before the "
"declarator in a function definition");
c_parser_skip_to_end_of_block_or_statement (parser);
return;
}
}
if (c_parser_next_token_is (parser, CPP_EQ)) if (c_parser_next_token_is (parser, CPP_EQ))
{ {
tree d; tree d;

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2014-05-01 Marek Polacek <polacek@redhat.com>
PR c/60915
* gcc.dg/pr60915.c: New test.
2014-05-01 Marek Polacek <polacek@redhat.com> 2014-05-01 Marek Polacek <polacek@redhat.com>
PR c/60257 PR c/60257

7
gcc/testsuite/gcc.dg/pr60915.c Normal file
View File

@ -0,0 +1,7 @@
/* PR c/60915 */
/* { dg-do compile } */
void /* { dg-error "attributes should be specified before the declarator in a function definition" } */
foo (void) __attribute__((__visibility__("default")))
{
}