git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[libbacktrace] Simplify memory management in build_address_map 

In the main loop in build_address_map, we first read the abbrevs into a local
variable abbrevs, and then allocate the corresponding unit, after which we assign
the abbrevs to the unit.  This results in dedicated free-upon-failure
handling for the variable, and extra code to make sure that free-upon-failure
doesn't trigger once the unit has taken ownership of the abbrevs.

Simplify this by reversing the order of abbrev reading and unit allocation,
and eliminating the abbrevs local variable.

Bootstrapped and reg-tested on x86_64.

2018-12-28  Tom de Vries  <tdevries@suse.de>

	* dwarf.c (build_address_map): Simplify by removing local variable
	abbrevs.

From-SVN: r267444
This commit is contained in:
Tom de Vries 2018-12-28 03:43:41 +00:00 committed by Tom de Vries
parent 40b8d3b253
commit d9aa0961ea
2 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libbacktrace/ChangeLog
View File

@ -1,3 +1,8 @@
2018-12-28 Tom de Vries <tdevries@suse.de>
* dwarf.c (build_address_map): Simplify by removing local variable
abbrevs.
2018-12-28 Ian Lance Taylor <iant@golang.org> 2018-12-28 Ian Lance Taylor <iant@golang.org>
Tom de Vries <tdevries@suse.de> Tom de Vries <tdevries@suse.de>

20
libbacktrace/dwarf.c
View File

@ -1432,7 +1432,6 @@ build_address_map (struct backtrace_state *state, uintptr_t base_address,
void *data, struct unit_addrs_vector *addrs) void *data, struct unit_addrs_vector *addrs)
{ {
struct dwarf_buf info; struct dwarf_buf info;
struct abbrevs abbrevs;
struct backtrace_vector units; struct backtrace_vector units;
size_t units_count; size_t units_count;
size_t i; size_t i;
@ -1457,7 +1456,6 @@ build_address_map (struct backtrace_state *state, uintptr_t base_address,
memset (&units, 0, sizeof units); memset (&units, 0, sizeof units);
units_count = 0; units_count = 0;
memset (&abbrevs, 0, sizeof abbrevs);
while (info.left > 0) while (info.left > 0)
{ {
const unsigned char *unit_data_start; const unsigned char *unit_data_start;
@ -1488,13 +1486,6 @@ build_address_map (struct backtrace_state *state, uintptr_t base_address,
goto fail; goto fail;
} }
abbrev_offset = read_offset (&unit_buf, is_dwarf64);
if (!read_abbrevs (state, abbrev_offset, dwarf_abbrev, dwarf_abbrev_size,
is_bigendian, error_callback, data, &abbrevs))
goto fail;
addrsize = read_byte (&unit_buf);
pu = ((struct unit **) pu = ((struct unit **)
backtrace_vector_grow (state, sizeof (struct unit *), backtrace_vector_grow (state, sizeof (struct unit *),
error_callback, data, &units)); error_callback, data, &units));
@ -1509,6 +1500,14 @@ build_address_map (struct backtrace_state *state, uintptr_t base_address,
*pu = u; *pu = u;
++units_count; ++units_count;
memset (&u->abbrevs, 0, sizeof u->abbrevs);
abbrev_offset = read_offset (&unit_buf, is_dwarf64);
if (!read_abbrevs (state, abbrev_offset, dwarf_abbrev, dwarf_abbrev_size,
is_bigendian, error_callback, data, &u->abbrevs))
goto fail;
addrsize = read_byte (&unit_buf);
u->unit_data = unit_buf.buf; u->unit_data = unit_buf.buf;
u->unit_data_len = unit_buf.left; u->unit_data_len = unit_buf.left;
u->unit_data_offset = unit_buf.buf - unit_data_start; u->unit_data_offset = unit_buf.buf - unit_data_start;
@ -1519,8 +1518,6 @@ build_address_map (struct backtrace_state *state, uintptr_t base_address,
u->comp_dir = NULL; u->comp_dir = NULL;
u->abs_filename = NULL; u->abs_filename = NULL;
u->lineoff = 0; u->lineoff = 0;
u->abbrevs = abbrevs;
memset (&abbrevs, 0, sizeof abbrevs);
/* The actual line number mappings will be read as needed. */ /* The actual line number mappings will be read as needed. */
u->lines = NULL; u->lines = NULL;
@ -1559,7 +1556,6 @@ build_address_map (struct backtrace_state *state, uintptr_t base_address,
} }
backtrace_vector_free (state, &units, error_callback, data); backtrace_vector_free (state, &units, error_callback, data);
} }
free_abbrevs (state, &abbrevs, error_callback, data);
if (addrs->count > 0) if (addrs->count > 0)
{ {
backtrace_vector_free (state, &addrs->vec, error_callback, data); backtrace_vector_free (state, &addrs->vec, error_callback, data);