git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

re PR target/33963 (Dllimport attribute wrongly accepted on typedefs) 

PR target/33963
	* tree.c (handle_dll_attribute): Disallow TYPE_DECLs for types
	other than structures and unions.

From-SVN: r132744
This commit is contained in:
Joseph Myers 2008-02-28 12:34:51 +00:00 committed by Joseph Myers
parent 3b3024215f
commit dde75838e9
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2008-02-28 Joseph Myers <joseph@codesourcery.com>
PR target/33963
* tree.c (handle_dll_attribute): Disallow TYPE_DECLs for types
other than structures and unions.
2008-02-28 Richard Guenther <rguenther@suse.de> 2008-02-28 Richard Guenther <rguenther@suse.de>
Revert: Revert:

10
gcc/tree.c
View File

@ -3971,6 +3971,16 @@ handle_dll_attribute (tree * pnode, tree name, tree args, int flags,
return NULL_TREE; return NULL_TREE;
} }
if (TREE_CODE (node) == TYPE_DECL
&& TREE_CODE (TREE_TYPE (node)) != RECORD_TYPE
&& TREE_CODE (TREE_TYPE (node)) != UNION_TYPE)
{
*no_add_attrs = true;
warning (OPT_Wattributes, "%qs attribute ignored",
IDENTIFIER_POINTER (name));
return NULL_TREE;
}
/* Report error on dllimport ambiguities seen now before they cause /* Report error on dllimport ambiguities seen now before they cause
any damage. */ any damage. */
else if (is_attribute_p ("dllimport", name)) else if (is_attribute_p ("dllimport", name))