git
/
gcc
mirror of git://gcc.gnu.org/git/gcc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clean up confusing vectype/vectype1 mixups in vect_create_epilog_for_reduction 

The following occured to me - hope it doesn't hide anything real.

	* tree-vect-loop.cc (vect_create_epilog_for_reduction): Move
	bitsize compute down to where it is used and consistently
	use vectype1 for element extraction.
This commit is contained in:
Richard Biener 2025-10-09 14:02:09 +02:00
parent c078309cda
commit e388710c46
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/tree-vect-loop.cc
View File

@ -5258,7 +5258,6 @@ vect_create_epilog_for_reduction (loop_vec_info loop_vinfo,
tree new_temp = NULL_TREE, new_name, new_scalar_dest; tree new_temp = NULL_TREE, new_name, new_scalar_dest;
gimple *epilog_stmt = NULL; gimple *epilog_stmt = NULL;
gimple *exit_phi; gimple *exit_phi;
tree bitsize;
tree def; tree def;
tree orig_name, scalar_result; tree orig_name, scalar_result;
imm_use_iterator imm_iter; imm_use_iterator imm_iter;
@ -5475,7 +5474,6 @@ vect_create_epilog_for_reduction (loop_vec_info loop_vinfo,
scalar_results.truncate (0); scalar_results.truncate (0);
scalar_results.reserve_exact (group_size); scalar_results.reserve_exact (group_size);
new_scalar_dest = vect_create_destination_var (scalar_dest, NULL); new_scalar_dest = vect_create_destination_var (scalar_dest, NULL);
bitsize = TYPE_SIZE (scalar_type);
/* True if we should implement SLP_REDUC using native reduction operations /* True if we should implement SLP_REDUC using native reduction operations
instead of scalar operations. */ instead of scalar operations. */
@ -5897,6 +5895,7 @@ vect_create_epilog_for_reduction (loop_vec_info loop_vinfo,
if (reduce_with_shift && (!slp_reduc || group_size == 1)) if (reduce_with_shift && (!slp_reduc || group_size == 1))
{ {
tree bitsize = TYPE_SIZE (TREE_TYPE (vectype1));
int element_bitsize = tree_to_uhwi (bitsize); int element_bitsize = tree_to_uhwi (bitsize);
/* Enforced by vectorizable_reduction, which disallows SLP reductions /* Enforced by vectorizable_reduction, which disallows SLP reductions
for variable-length vectors and also requires direct target support for variable-length vectors and also requires direct target support
@ -5965,9 +5964,10 @@ vect_create_epilog_for_reduction (loop_vec_info loop_vinfo,
dump_printf_loc (MSG_NOTE, vect_location, dump_printf_loc (MSG_NOTE, vect_location,
"Reduce using scalar code.\n"); "Reduce using scalar code.\n");
tree compute_type = TREE_TYPE (vectype1);
tree bitsize = TYPE_SIZE (compute_type);
int vec_size_in_bits = tree_to_uhwi (TYPE_SIZE (vectype1)); int vec_size_in_bits = tree_to_uhwi (TYPE_SIZE (vectype1));
int element_bitsize = tree_to_uhwi (bitsize); int element_bitsize = tree_to_uhwi (bitsize);
tree compute_type = TREE_TYPE (vectype);
gimple_seq stmts = NULL; gimple_seq stmts = NULL;
FOR_EACH_VEC_ELT (reduc_inputs, i, vec_temp) FOR_EACH_VEC_ELT (reduc_inputs, i, vec_temp)
{ {