Commit Graph

165715 Commits

Author SHA1 Message Date
Cesar Philippidis 65b5f49699 Correct the reported line number in C++ combined OpenACC directives
The C++ FE doesn't set the expr_location of the split acc loop in combined acc
parallel/kernels loop directives. This only happens for with combined
directives, otherwise cp_parser_omp_construct would be responsible for setting
the location. After fixing this bug, I was able to resolve a couple of long
standing diagnostics discrepancies between the C/C++ FEs in the test suite.

	gcc/cp/
	* parser.c (cp_parser_oacc_kernels_parallel): Adjust EXPR_LOCATION
	on the combined acc loop.
	gcc/testsuite/
	* c-c++-common/goacc/combined-directives-3.c: New test.
	* c-c++-common/goacc/loop-2-kernels.c (void K): Adjust test.
	* c-c++-common/goacc/loop-2-parallel.c (void P): Adjust test.
	* c-c++-common/goacc/loop-3.c (void p2): Adjust test.

Reviewed-by: Thomas Schwinge <thomas@codesourcery.com>

From-SVN: r266923
2018-12-09 13:48:26 +01:00
Thomas Schwinge 4b195d270c Use existing middle end checking for Fortran OpenACC loop clauses
Don't duplicate in the Fortran front end what's generically being checked in
the middle end.

	gcc/fortran/
	* openmp.c (resolve_oacc_loop_blocks): Remove checking of OpenACC
	loop clauses.
	gcc/testsuite/
	* gfortran.dg/goacc/loop-2-kernels.f95: Update.
	* gfortran.dg/goacc/loop-2-parallel.f95: Likewise.
	* gfortran.dg/goacc/nested-parallelism.f90: Likewise.

From-SVN: r266922
2018-12-09 13:47:58 +01:00
Thomas Schwinge 877009a5d9 Split up "gfortran.dg/goacc/loop-2.f95"
gcc/testsuite/
	* gfortran.dg/goacc/loop-2.f95: Split into...
	* gfortran.dg/goacc/loop-2-kernels-nested.f95: ... this new
	file...
	* gfortran.dg/goacc/loop-2-kernels-tile.f95: ..., and this new
	file...
	* gfortran.dg/goacc/loop-2-kernels.f95: ..., and this new file...
	* gfortran.dg/goacc/loop-2-parallel-3.f95: ..., and this new
	file...
	* gfortran.dg/goacc/loop-2-parallel-nested.f95: ..., and this new
	file...
	* gfortran.dg/goacc/loop-2-parallel-tile.f95: ..., and this new
	file...
	* gfortran.dg/goacc/loop-2-parallel.f95: ..., and this new file.

From-SVN: r266921
2018-12-09 13:47:47 +01:00
Thomas Schwinge b22b7d462e [PR88420] Fortran OpenACC "Clause SEQ conflicts with INDEPENDENT"
The Fortran front end declares that the OpenACC "Clause SEQ conflicts with
INDEPENDENT".  While that combination doesn't make too much sense indeed, it's
still valid; these are orthogonal concepts.

	gcc/fortran/
	PR fortran/88420
	* openmp.c (resolve_oacc_loop_blocks): Remove "Clause SEQ
	conflicts with INDEPENDENT" diagnostic.
	gcc/testsuite/
	PR fortran/88420
	* gfortran.dg/goacc/loop-1-2.f95: Update.
	* gfortran.dg/goacc/loop-1.f95: Likewise.

From-SVN: r266920
2018-12-09 13:47:35 +01:00
Thomas Schwinge 84ca08d2d5 Coalesce host to device transfers in libgomp: not for link pointer
libgomp/
	* target.c (gomp_map_vars): Call gomp_copy_host2dev instead of
	devicep->host2dev_func.

Co-Authored-By: Jakub Jelinek <jakub@redhat.com>

From-SVN: r266919
2018-12-09 13:47:23 +01:00
Bin Cheng 5a686851dc ipa-cp.c (update_profiling_info): Call adjust_for_ipa_scaling for zero profile count.
* ipa-cp.c (update_profiling_info): Call adjust_for_ipa_scaling for
	zero profile count.

From-SVN: r266918
2018-12-09 06:37:56 +00:00
Steven G. Kargl 019761d224 re PR fortran/88048 (ICE in check_data_variable, at fortran/resolve.c:15491)
2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/88048
	* resolve.c (check_data_variable): Named constant cannot be a
	data object.

2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/88048
	* gfortran.dg/pr88048.f90: New test.

From-SVN: r266916
2018-12-09 06:09:47 +00:00
Steven G. Kargl 094a0eccf9 20180-12-08 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/87945
	* decl.c (var_element): Inquiry parameters cannit be data objects.

20180-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/87945
	* gfortran.dg/pr87945_1.f90: New test.
	* gfortran.dg/pr87945_2.f90: New test.

From-SVN: r266915
2018-12-09 04:02:44 +00:00
Steven G. Kargl 36f972b713 re PR fortran/88025 (ICE in gfc_apply_init, at fortran/expr.c:4468)
2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/88025
	* expr.c (gfc_apply_init):  Remove asserts that cannot trigger.
	Check for a NULL pointer.

2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/88025
	* gfortran.dg/pr88025.f90: New test.

From-SVN: r266913
2018-12-09 01:02:41 +00:00
GCC Administrator 2bf27f6b65 Daily bump.
From-SVN: r266912
2018-12-09 00:16:33 +00:00
Segher Boessenkool b705502821 c: Delete a stray line in asm inline
I noticed I accidentally copied a line too many from the "volatile"
handling to the "inline" handling.  This fixes it.


gcc/c/
	* c-parser (c_parser_asm_statement) [RID_INLINE]: Delete stray line
	setting "quals".

From-SVN: r266909
2018-12-08 23:31:09 +01:00
Steven G. Kargl 4874b4d26c re PR fortran/88357 (ICE in parse_associate, at fortran/parse.c:4568)
2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/88357
	* class.c (insert_component_ref): Check for NULL pointer and 
	previous error message issued.
	* parse.c (parse_associate): Check for NULL pointer.
	* resolve.c (resolve_assoc_var): Check for NULL pointer.

2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

	* gfortran.dg/pr88357_1.f90: New test.
	* gfortran.dg/pr88357_2.f90: New test.

From-SVN: r266908
2018-12-08 18:09:05 +00:00
Jakub Jelinek 47e1596cc1 re PR fortran/88304 (ICE in use_pointer_in_frame, at tree-nested.c:267)
PR fortran/88304
	* tree-nested.c (convert_local_reference_stmt): Handle clobbers where
	lhs is not a decl normally, don't call use_pointer_in_frame on that
	lhs.

	* gfortran.fortran-torture/compile/pr88304-2.f90: New test.

From-SVN: r266907
2018-12-08 14:37:49 +01:00
Eric Botcazou dfe1fe91db re PR rtl-optimization/88390 (g++.dg/tree-prof/pr57451.C FAILs)
PR rtl-optimization/88390
	* dwarf2cfi.c (struct dw_cfi_row): Add window_save field.
	(cfi_row_equal_p): Compare it.
	(dwarf2out_frame_debug_cfa_window_save): Add FAKE parameter.
	If FAKE is false, set window_save of the current row.
	(dwarf2out_frame_debug) <REG_CFA_TOGGLE_RA_MANGLE>: Call above
	function with FAKE parameter set to true.
	<REG_CFA_WINDOW_SAVE>: Likewise but with FAKE parameter set to false.
	(change_cfi_row): Emit a DW_CFA_GNU_window_save if necessary.

From-SVN: r266906
2018-12-08 11:07:53 +00:00
Rainer Orth 0a6ac1b289 Pass GDCFLAGS and CCASFLAGS to libphobos subdirs
* Makefile.am (AM_MAKEFLAGS): Pass CCASFLAGS, GDCFLAGS.
	* Makefile.in: Regenerate.

From-SVN: r266905
2018-12-08 10:02:19 +00:00
Jakub Jelinek 6997628d35 re PR libgomp/87995 (libgomp.c/../libgomp.c-c++-common/cancel-taskgroup-3.c fails consistently after r265930)
PR libgomp/87995
	* testsuite/libgomp.c-c++-common/cancel-taskgroup-3.c: Require
	tls_runtime effective target.
	(t): New threadprivate variable.
	(main): Set t in threads which execute iterations of the worksharing
	loop.  Propagate that to the task after the loop and don't abort
	if the current taskgroup hasn't been cancelled.

From-SVN: r266904
2018-12-08 09:58:24 +01:00
GCC Administrator b03a449727 Daily bump.
From-SVN: r266903
2018-12-08 00:16:34 +00:00
Paolo Carlini fee11e77e5 decl2.c (grokbitfield): Use DECL_SOURCE_LOCATION in error messages about bit-fields with function type...
/cp
2018-12-07  Paolo Carlini  <paolo.carlini@oracle.com>

	* decl2.c (grokbitfield): Use DECL_SOURCE_LOCATION in error messages
	about bit-fields with function type, warn_if_not_aligned type, and
	static bit-fields; avoid DECL_NAME for unnamed declarations.

/testsuite
2018-12-07  Paolo Carlini  <paolo.carlini@oracle.com>

	* g++.dg/other/bitfield7.C: New.
	* g++.dg/parse/bitfield8.C: Likewise.
	* g++.dg/parse/bitfield9.C: Likewise.
	* g++.dg/pr53037-4.C: Test the locations too.

From-SVN: r266900
2018-12-07 17:48:39 +00:00
Peter Bergner 96e14fda0d re PR target/87496 (ICE in aggregate_value_p at gcc/function.c:2046)
gcc/
	PR target/87496
	* config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow
	-mabi=ieeelongdouble and -mabi=ibmlongdouble without -mlong-double-128.
	Do not error for -mabi=ibmlongdouble and no ISA 2.06 support.
	* doc/invoke.texi: Document -mabi=ibmlongdouble and -mabi=ieeelongdouble
	require -mlong-double-128.

gcc/testsuite/
	PR target/87496
	* gcc.target/powerpc/pr87496.c: Rename from this...
	* gcc.target/powerpc/pr87496-1.c: ...to this.  Update comment.
	* gcc.target/powerpc/pr87496-2.c: New test.
	* gcc.target/powerpc/pr87496-3.c: New test.

From-SVN: r266899
2018-12-07 11:33:55 -06:00
Kyrylo Tkachov 886f092f59 [AArch64][2/2] Add sve_width -moverride tunable
On top of the previous patch that implements TARGET_ESTIMATED_POLY_VALUE
and adds an sve_width tuning field to the CPU structs, this patch implements
an -moverride knob to adjust this sve_width field to allow for experimentation.
Again, reminder that this only has an effect when compiling for VLA-SVE that is,
without msve-vector-bits=<foo>. This just adjusts tuning heuristics in the compiler,,
like profitability thresholds for vectorised versioned loops, and others.

It can be used, for example like -moverride=sve_width=256 to set the sve_width
tuning field to 256. Widths outside of the accepted SVE widths [128 - 2048] are rejected
as you'd expect.

    * config/aarch64/aarch64.c (aarch64_tuning_override_functions): Add
    sve_width entry.
    (aarch64_parse_sve_width_string): Define.


    * gcc.target/aarch64/sve/override_sve_width_1.c: New test.

From-SVN: r266898
2018-12-07 17:05:21 +00:00
Jeff Law c844c4028f gimple-ssa-evrp-analyze.h (class evrp_range_analyzer): Add m_update_global_ranges member.
* gimple-ssa-evrp-analyze.h (class evrp_range_analyzer): Add
	m_update_global_ranges member.  Add corresponding argument to ctor.
	* gimple-ssa-evrp-analyze.c
	(evrp_range_analyzer::evrp_range_analyzer): Add new argument and
	initialize m_update_global_ranges.
	(evrp_range_analyzer::set_ssa_range_info): Assert that we are
	updating global ranges.
	(evrp_range_analyzer::record_ranges_from_incoming_edge): Only
	update global ranges if explicitly requested.
	(evrp_range_analyzer::record_ranges_from_phis): Similarly.
	(evrp_range_analyzer::record_ranges_from_stmt): Similarly.
	* gimple-ssa-evrp.c (evrp_dom_walker): Pass new argument to
	evrp_range_analyzer ctor.
	* gimple-ssa-sprintf.c (sprintf_dom_walker): Similarly.
	* tree-ssa-dom.c (dom_opt_dom_walker): Similarly.

	* gcc.c-torture/builtins/strnlen.x: New file to filter -Og from
	options to test.

From-SVN: r266897
2018-12-07 10:02:11 -07:00
Kyrylo Tkachov 2d56d6ba9c [AArch64][1/2] Implement TARGET_ESTIMATED_POLY_VALUE
The hook TARGET_ESTIMATED_POLY_VALUE allows a target to give an estimate for a poly_int run-time value.
It is used exclusively in tuning decisions, things like estimated loop iterations, probabilities etc.
It is not relied on for correctness.

If we know the SVE width implemented in hardware we can make more more
informed decisions in the implementation of TARGET_ESTIMATED_POLY_VALUE,
even when compiling for VLA vectorisation.

This patch adds an sve_width field to our tuning structs and sets it for
the current CPU tunings.

A new value is introduced to the aarch64_sve_vector_bits_enum enum that indicates
that SVE is not available: SVE_NOT_IMPLEMENTED. I set it to the same value as SVE_SCALABLE
so that parts of the aarch64 backend that follow the pattern:
if (vector_width == SVE_SCALABLE)
  do_vla_friendly_action ()
else
  assume_specific_width_for_correctness ()

continue to work without change, but the CPU tuning structs can use a more
appropriate moniker for indicating the absence of SVE.

This sets sve_width to SVE_NOT_IMPLEMENTED for all cores.
I aim to add an -moverride switch in the next patch that allows a power user to experiment
with different values of it for investigations.

	* config/aarch64/aarch64-opts.h (aarch64_sve_vector_bits_enum):
	Add SVE_NOT_IMPLEMENTED value.
	* config/aarch64/aarch64-protos.h (struct tune_params): Add sve_width
	field.
	* config/aarch64/aarch64.c (generic_tunings,cortexa35_tunings,
	cortexa53_tunings, cortexa57_tunings, cortexa72_tunings,
	cortexa73_tunings, exynosm1_tunings, thunderx_tunings,
	thunderx_tunings, tsv110_tunings, xgene1_tunings, qdf24xx_tunings,
	saphira_tunings, thunderx2t99_tunings, emag_tunings):
	Specify sve_width.
	(aarch64_estimated_poly_value): Define.
	(TARGET_ESTIMATED_POLY_VALUE): Define.

From-SVN: r266896
2018-12-07 16:48:39 +00:00
Paul A. Clarke 11f1ae2aae [rs6000] mmintrin.h: fix use of "vector"
A recent patch inadvertently added the use of "vector" to mmintrin.h
when all such uses should be "__vector".

[gcc]

2018-12-07  Paul A. Clarke  <pc@us.ibm.com>

	PR target/88408
	* config/rs6000/mmintrin.h (_mm_packs_pu16): Correctly use "__vector".

From-SVN: r266895
2018-12-07 16:32:34 +00:00
Vladimir Makarov 66a0970a1f re PR rtl-optimization/88349 ([MIPS] Redundant store instructions generated start with r266385)
2018-12-07  Vladimir Makarov  <vmakarov@redhat.com>

	PR rtl-optimization/88349
	* ira-costs.c (record_operand_costs): Check bigger reg class on
	NO_REGS.

2018-12-07  Vladimir Makarov  <vmakarov@redhat.com>

	PR rtl-optimization/88349
	* gcc.target/mips/pr88349.c: New.

From-SVN: r266894
2018-12-07 16:08:17 +00:00
Jakub Jelinek 29f0d7d457 re PR c++/86669 (Complete object constructor clone omits length for a c++11 braced initialiser)
PR c++/86669
	* call.c (make_temporary_var_for_ref_to_temp): Call pushdecl even for
	automatic vars.

	* g++.dg/cpp0x/initlist105.C: New test.
	* g++.dg/cpp0x/initlist106.C: New test.
	* g++.dg/other/pr86669.C: New test.

From-SVN: r266893
2018-12-07 16:20:04 +01:00
Richard Sandiford 26004f51f9 [AArch64][SVE] Remove unnecessary PTRUEs from integer arithmetic
When using the unpredicated immediate forms of MUL, LSL, LSR and ASR,
the rtl patterns would still have the predicate operand we created for
the other forms.  This patch splits the patterns after reload in order
to get rid of the predicate, like we already do for WHILE.

2018-12-07  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
	* config/aarch64/aarch64-sve.md (*mul<mode>3, *v<optab><mode>3):
	Split the patterns after reload if we don't need the predicate
	operand.
	(*post_ra_mul<mode>3, *post_ra_v<optab><mode>3): New patterns.

gcc/testsuite/
	* gcc.target/aarch64/sve/pred_elim_2.c: New test.

From-SVN: r266892
2018-12-07 15:03:15 +00:00
Richard Sandiford 740c1ed77c [AArch64][SVE] Remove unnecessary PTRUEs from FP arithmetic
When using the unpredicated all-register forms of FADD, FSUB and FMUL,
the rtl patterns would still have the predicate operand we created for
the other forms.  This patch splits the patterns after reload in order
to get rid of the predicate, like we already do for WHILE.

2018-12-07  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
	* config/aarch64/iterators.md (SVE_UNPRED_FP_BINARY): New code
	iterator.
	(sve_fp_op): Handle minus and mult.
	* config/aarch64/aarch64-sve.md (*add<mode>3, *sub<mode>3)
	(*mul<mode>3): Split the patterns after reload if we don't
	need the predicate operand.
	(*post_ra_<sve_fp_op><mode>3): New pattern.

gcc/testsuite/
	* gcc.target/aarch64/sve/pred_elim_1.c: New test.

From-SVN: r266891
2018-12-07 15:01:47 +00:00
Ian Lance Taylor 5a58929be8 runtime: add missing return for non-GNU/Linux version of tgkill
Path from Rainer Orth.
    
    Reviewed-on: https://go-review.googlesource.com/c/153118

From-SVN: r266890
2018-12-07 14:22:55 +00:00
Rainer Orth e914864fab Add forgotten PR marker.
From-SVN: r266889
2018-12-07 13:56:17 +00:00
Rainer Orth 64b82dfa3b Build gcc.target/i386/ipa-stack-alignment-2.c with -fomit-frame-pointer
* gcc.target/i386/ipa-stack-alignment-2.c: Add
	-fomit-frame-pointer to dg-options.

From-SVN: r266888
2018-12-07 13:01:20 +00:00
Nick Clifton e96d1d8c78 Add a recursion limit to libiberty's demangling code. The limit is enabled by default, but can be disabled via a new demangling option.
include	* demangle.h (DMGL_NO_RECURSE_LIMIT): Define.
        (DEMANGLE_RECURSION_LIMIT): Define

	PR 87681
	PR 87675
	PR 87636
	PR 87350
	PR 87335
libiberty * cp-demangle.h (struct d_info): Add recursion_level field.
	* cp-demangle.c (d_function_type): Add recursion counter.
	If the recursion limit is reached and the check is not disabled,
	then return with a failure result.
	(cplus_demangle_init_info): Initialise the recursion_level field.
        (d_demangle_callback): If the recursion limit is enabled, check
	for a mangled string that is so long that there is not enough
	stack space for the local arrays.
        * cplus-dem.c (struct work): Add recursion_level field.
	(squangle_mop_up): Set the numb and numk fields to zero.
	(work_stuff_copy_to_from): Handle the case where a btypevec or 
	ktypevec field is NULL.
	(demangle_nested_args): Add recursion counter.  If
	the recursion limit is not disabled and reached, return with a
	failure result.

From-SVN: r266886
2018-12-07 10:33:30 +00:00
Bin Cheng 0876cb1c7b profile-count.h (profile_count::oeprator>=): Fix typo by inverting return condition when *this is precise zero.
* profile-count.h (profile_count::oeprator>=): Fix typo by inverting
	return condition when *this is precise zero.

From-SVN: r266885
2018-12-07 09:49:13 +00:00
GCC Administrator 09fb2e2c94 Daily bump.
From-SVN: r266884
2018-12-07 00:16:25 +00:00
Jakub Jelinek 820037ecf6 re PR target/85593 (GCC on ARM allocates R3 for local variable when calling naked function with O2 optimizations enabled)
PR target/85593
	* final.c (rest_of_handle_final): Don't call collect_fn_hard_reg_usage
	for functions with naked attribute.

	* gcc.target/i386/pr85593.c: New test.

From-SVN: r266881
2018-12-07 00:41:04 +01:00
Jakub Jelinek 1e41b18448 re PR rtl-optimization/85770 (ICE: in lra_eliminate, at lra-eliminations.c:1439 with -march=nano-1000)
PR rtl-optimization/85770
	* gcc.target/i386/pr85770.c: Require int128 effective target.

From-SVN: r266880
2018-12-07 00:39:12 +01:00
Jakub Jelinek d4722625ae re PR fortran/88377 (ICE in gfc_omp_clause_copy_ctor, at fortran/trans-openmp.c:614)
PR fortran/88377
	* trans-openmp.c (gfc_omp_clause_default_ctor,
	gfc_omp_clause_copy_ctor, gfc_omp_clause_assign_op,
	gfc_omp_clause_linear_ctor, gfc_omp_clause_dtor): Only consider
	GFC_DECL_GET_SCALAR_ALLOCATABLE vars as scalar allocatables if they
	have pointer type.

	* gfortran.dg/gomp/pr88377.f90: New test.

From-SVN: r266879
2018-12-07 00:29:04 +01:00
Jakub Jelinek b8a003c165 re PR tree-optimization/88367 (-fno-delete-null-pointer-checks doesn't work properly)
PR c/88367
	* tree-vrp.c (extract_range_from_binary_expr): For POINTER_PLUS_EXPR
	with -fno-delete-null-pointer-checks, set_nonnull only if the pointer
	is non-NULL and offset is known to have most significant bit clear.
	* vr-values.c (vr_values::vrp_stmt_computes_nonzero): For ADDR_EXPR
	of MEM_EXPR, return true if the MEM_EXPR has non-zero offset with
	most significant bit clear.  If offset does have most significant bit
	set and -fno-delete-null-pointer-checks, don't return true even if
	the base pointer is non-NULL.

	* gcc.dg/tree-ssa/pr88367.c: New test.

From-SVN: r266878
2018-12-07 00:28:04 +01:00
Jakub Jelinek ff8ba86f44 re PR c++/87506 (ICE with inherited constexpr constructor with const argument)
PR c++/87506
	* constexpr.c (adjust_temp_type): Handle EMPTY_CLASS_EXPR.

	* g++.dg/cpp0x/constexpr-87506.C: New test.

From-SVN: r266877
2018-12-07 00:25:10 +01:00
Paolo Carlini 3c1eaf67e9 class.c (check_bitfield_decl): In error message about non-integral type print the type itself too.
/cp
2018-12-06  Paolo Carlini  <paolo.carlini@oracle.com>

	* class.c (check_bitfield_decl): In error message about non-integral
	type print the type itself too.
	* decl.c (grokdeclarator): Do not ICE on unnamed bit-fields declared
	friends; when calling build_decl for a FIELD_DECL possibly pass the
	declarator->id_loc.

/testsuite
2018-12-06  Paolo Carlini  <paolo.carlini@oracle.com>

	* g++.dg/parse/bitfield7.C: New.
	* g++.dg/other/bitfield2.C: Check location and type.
	* g++.dg/parse/bitfield1.C: Likewise.
	* g++.dg/parse/bitfield2.C: Likewise.

From-SVN: r266876
2018-12-06 23:20:16 +00:00
Alexandre Oliva d7711adcd5 [PR86747] tsubst friend tpl ctxt before looking it up for dupes
When a member template is redeclared as a friend, we enter the context
of the member before looking it up, and then we check that the decls
are compatible.  However, when the member template references template
types of the enclosing context, say an enclosing template class, the
compare fails because the friend decl is already tsubsted, whereas the
looked up name isn't.

The problem is that the enclosing context is taken from the friend
declaration before tsubsting it, so we look up in the context of the
generic template instead of that of the tsubsted one we're
specializing.  The solution is to tsubst the enclosing context when
it's a non-namespace scope.

for  gcc/cp/ChangeLog

	PR c++/86747
	* pt.c (tsubst_friend_class): Enter tsubsted class context.

for  gcc/testsuite/ChangeLog

	PR c++/86747
	* g++.dg/pr86747.C: New.

From-SVN: r266875
2018-12-06 23:18:40 +00:00
Alexandre Oliva 0d699def39 [PR86397] resolve nondependent noexcept specs early in C++1[14]
build_noexcept_spec refrained from resolving nondependent noexcept
expressions when they were not part of the function types (C++ 11 and
14).  This caused problems during mangling: canonical_eh_spec, when
called on the template function type, would find an unresolved but not
explicitly deferred expression, and nothrow_spec_p would reject it.

We could relax the mangling logic to skip canonical_eh_spec, but since
-Wnoexcept-type warns when mangling function names that change as
noexcept specs become part of types and of mangling in C++17, and the
test at mangling time may give incorrect results if the spec is not
resolved, we might as well keep things simple and resolve nondependent
noexcept specs sooner rather than later.  This is what this patch does.


for  gcc/cp/ChangeLog

	PR c++/86397
	* except.c (build_noexcept_spec): Resolve nondependent
	expressions.

for gcc/testsuite/ChangeLog

	PR c++/86397
	* g++.dg/cpp0x/pr86397-1.C: New.
	* g++.dg/cpp0x/pr86397-2.C: New.

From-SVN: r266874
2018-12-06 23:18:30 +00:00
Alexandre Oliva 695be09234 avoid null ptr deref in cselib_record_sets
Jeff Law tells me h8300-elf fails gcc.c-torture/compile/pr49029.c
with -O2 -g -mint32 -mh.  This patch fixes it.

The problem is that strict low part handling in cselib_record_sets
assumes src_elt is not NULL.  That src_elt is taken from a strict low
part set, but it won't always have a src_elt to begin with.  In this
case, it's because src is a volatile MEM; we don't record values for
those.

Although we could fix the problem by testing for a NULL src_elt before
creating the zero extends corresponding to strict low part sets of
formerly const0_rtx REGs, there's no point in recording the additional
set that we won't be able to use anyway.

We could still record that the whole register has a zero-extend of
the value stored in the narrower-mode strict low part of the register,
but is that of any use?  I guess not, but if we find otherwise, we can
change that later.


for  gcc/ChangeLog

	* cselib.c (cselib_record_sets): Skip strict low part sets
	with NULL src_elt.

From-SVN: r266873
2018-12-06 23:18:19 +00:00
Paul A. Clarke 4cbb7085f0 [rs6000] Enable x86-compat vector intrinsics testing
The testsuite tests for the compatibility implementations of x86 vector
intrinsics for "powerpc" had been inadvertently made to PASS
without actually running the test code.

This patch removes the code which kept the tests from running the actual
test code.

2018-12-06  Paul A. Clarke  <pc@us.ibm.com>

[gcc/testsuite]

	PR target/88316
	* gcc.target/powerpc/bmi-check.h: Remove test for
	__BUILTIN_CPU_SUPPORTS__, thereby enabling test code to run.
	* gcc.target/powerpc/bmi2-check.h: Likewise.
	* gcc.target/powerpc/mmx-check.h: Likewise.
	* gcc.target/powerpc/sse-check.h: Likewise.
	* gcc.target/powerpc/sse2-check.h: Likewise.
	* gcc.target/powerpc/sse3-check.h: Likewise.

From-SVN: r266870
2018-12-06 22:14:55 +00:00
Paul A. Clarke 98e07d5c54 [rs6000] Fix x86-compat vector intrinsics testcases for BE, 32bit
Fix general endian issues found in the test cases for thecompatibility
implementations of the x86 vector intrinsics.  (The tests had been
inadvertently made to PASS without actually running the test code.
A later patch fixes this issue.)

Additionally, a new <smmintrin.h> is added, as some of the APIs therein are
now used by the test cases.  It is _not_ a complete implementation of the
SSE4 interfaces, only the few "extract" interfaces uses by the tests.

2018-12-06  Paul A. Clarke  <pc@us.ibm.com>

[gcc]

	PR target/88316
	* config/rs6000/smmintrin.h: New file.
	* config.gcc: Add smmintrin.h to extra_headers for powerpc*-*-*.

[gcc/testsuite]

	PR target/88316
	* gcc.target/powerpc/mmx-packssdw-1.c: Fixes for big-endian.
	* gcc.target/powerpc/mmx-packsswb-1.c: Likewise.
	* gcc.target/powerpc/mmx-packuswb-1.c: Likewise.
	* gcc.target/powerpc/mmx-pmulhw-1.c: Likewise.
	* gcc.target/powerpc/sse-cvtpi32x2ps-1.c: Likewise.
	* gcc.target/powerpc/sse-cvtpu16ps-1.c: Likewise.
	* gcc.target/powerpc/sse-cvtss2si-1.c: Likewise.
	* gcc.target/powerpc/sse-cvtss2si-2.c: Likewise.
	* gcc.target/powerpc/sse2-pshufhw-1.c: Likewise.
	* gcc.target/powerpc/sse2-pshuflw-1.c: Likewise.

From-SVN: r266869
2018-12-06 22:11:01 +00:00
Paul A. Clarke 60c703ed1e [rs6000] x86-compat vector intrinsics fixes for BE, 32bit
Fix general endian and 32-bit mode issues found in the
compatibility implementations of the x86 vector intrinsics when running the
associated test suite tests.  (The tests had been inadvertently made to PASS
without actually running the test code.  A later patch fixes this issue.)

2018-12-03  Paul A. Clarke  <pc@us.ibm.com>

	PR target/88316
	* config/rs6000/mmintrin.h (_mm_unpackhi_pi8): Fix for big-endian.
	(_mm_unpacklo_pi8): Likewise.
	(_mm_mulhi_pi16): Likewise.
	(_mm_packs_pi16): Fix for big-endian. Use preferred API.
	(_mm_packs_pi32): Likewise.
	(_mm_packs_pu16): Likewise.
	* config/rs6000/xmmintrin.h (_mm_cvtss_si32): Fix for big-endian.
	(_mm_cvtss_si64): Likewise.
	(_mm_cvtpi32x2_ps): Likewise.
	(_mm_shuffle_ps): Likewise.
	(_mm_movemask_pi8): Likewise.
	(_mm_mulhi_pu16): Likewise.
	(_mm_sad_pu8): Likewise.
	(_mm_sad_pu8): Likewise.
	(_mm_cvtpu16_ps): Fix for big-endian. Use preferred API.
	(_mm_cvtpu8_ps): Likewise.
	(_mm_movemask_ps): Better #else case for big-endian (no functional
	change).
	(_mm_shuffle_pi16): Likewise.
	* config/rs6000/emmintrin.h (_mm_movemask_pd): Fix for big-endian.
	Better #else case for big-endian (no functional change).
	(_mm_movemask_epi8): Likewise.
	(_mm_shufflehi_epi16): Likewise.
	(_mm_shufflelo_epi16): Likewise.
	(_mm_shuffle_epi32): Likewise.
	(_mm_mul_epu32): Fix for big-endian.
	(_mm_bsrli_si128): Likewise.
	(_mm_cvtps_pd): Better #else case for big endian.
	(_mm_mulhi_epi16): Likewise.
	(_mm_mul_epu32): Likewise.
	(_mm_slli_si128): Likewise.
	(_mm_sll_epi16): Likewise.
	(_mm_sll_epi32): Likewise.
	(_mm_sra_epi16): Likewise.
	(_mm_sra_epi32): Likewise.
	(_mm_srl_epi16): Likewise.
	(_mm_srl_epi32): Likewise.
	(_mm_mulhi_epu16): Likewise.
	(_mm_sad_epu8): Likewise.
	* config/rs6000/pmmintrin.h (_mm_hadd_ps): Fix for big-endian.
	(_mm_sub_ps): Likewise.
	* config/rs6000/mmintrin.h (_mm_cmpeq_pi8): Fix for 32-bit mode.
	* gcc/config/rs6000/tmmintrin.h (_mm_alignr_epi8): Use ENDIAN
	macros consistently (no functional changes).
	(_mm_alignr_pi8): Likewise.

From-SVN: r266868
2018-12-06 22:03:25 +00:00
Jason Merrill 5c8b3702e3 PR c++/88136 - -Wdeprecated-copy false positives
Deprecating the copy operations because the class has a user-provided
destructor turns out to have too many false positives; this patch adjusts
-Wdeprecated-copy to only deprecate if the other copy operation is
user-provided.  To get the earlier behavior, people can explicitly request
it with -Wdeprecated-copy-dtor.

gcc/c-family/
	* c.opt (Wdeprecated-copy-dtor): New.
	(Wdeprecated-copy): Move to -Wextra.
gcc/cp/
	* class.c (classtype_has_depr_implicit_copy): Rename from
	classtype_has_user_copy_or_dtor.
	* method.c (lazily_declare_fn): Adjust.
	* decl2.c (cp_warn_deprecated_use): Refer to -Wdeprecated-copy-dtor
	if deprecation is due to a destructor.

From-SVN: r266867
2018-12-06 16:17:08 -05:00
Iain Sandoe 6e00bd6eb2 Darwin - fix PR c++/87380
This is [intentionally] broken C++ ABI, that was catering for a
tool problem that existed in a very old Darwin toolchain.

The issue is not present after Darwin7 (using default system
tools) so confine the fix to that revision or earlier.

2018-12-06  Iain Sandoe  <iain@sandoe.co.uk>

	PR c++/87380
	* config/darwin.h (TARGET_WEAK_NOT_IN_ARCHIVE_TOC) Remove; use the
	default.
	* config/rs6000/darwin7.h (TARGET_WEAK_NOT_IN_ARCHIVE_TOC): New.

From-SVN: r266866
2018-12-06 20:09:26 +00:00
Marek Polacek 89a249f2ec PR c++/88373 - wrong parse error with ~.
* parser.c (cp_parser_template_name): Check tag_type for
	none_type.

	* g++.dg/cpp2a/fn-template19.C: New test.

From-SVN: r266865
2018-12-06 19:43:17 +00:00
Iain Sandoe c438ab79bf Darwin fix libstdc++ build warnings.
GCC does not export construction vtable symbols from shared libraries.

The symbols are marked hidden in the objects; for Darwin that makes
them also external (“private_extern” is Darwin’s hidden) which means
that they show up in the list of possible symbols for export from
libstdc++, and there are sufficiently relaxed match conditions that
they reach the exports list.   When Darwin’s static linker encounters
them it generates a warning that they cannot be exported.  This patch
prunes them from the list of symbols to be considered, thus
eliminating the warnings. No functional Change inended to the library
exports.

2018-12-06  Iain Sandoe  <iain@sandoe.co.uk>

	* scripts/make_exports.pl (check names): Don’t try to export
	construction vtable symbols.

From-SVN: r266864
2018-12-06 19:42:21 +00:00
Jonathan Wakely 881e947ebd Fix PR libstdc++/64883 Darwin headers use always_inline so don't test that
Because darwin system headers use always_inline rather than
    __always_inline__ the libstdc++ test will fail, even if our headers only
    use the reserved form of the attribute. Don't test it on Darwin, and
    assume that testing on other targets will catch any accidental misuses
    in libstdc++ headers.
 
2018-12-06  Jonathan Wakely  <jwakely@redhat.com>
	    Iain Sandoe  <iain@sandoe.co.uk>

            PR libstdc++/64883
            * testsuite/17_intro/headers/c++1998/all_attributes.cc: Don't test
            always_inline on Darwin.
            * testsuite/17_intro/headers/c++2011/all_attributes.cc: Likewise.
            * testsuite/17_intro/headers/c++2014/all_attributes.cc: Likewise.
            * testsuite/17_intro/headers/c++2017/all_attributes.cc: Likewise.
            * testsuite/17_intro/headers/c++2020/all_attributes.cc: Likewise.


Co-Authored-By: Iain Sandoe <iain@sandoe.co.uk>

From-SVN: r266863
2018-12-06 19:21:32 +00:00