git/linux-cryptodev-2.6
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git synced 2026-04-18 03:23:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

rtc: nxp-bbnsm: Use resource managed API to simplify code

Browse Source 
Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the
error handling code and 'driver.remove()' hook.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20250205-rtc-cleanup-v1-2-66165678e089@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Peng Fan
2025-02-05 08:58:20 +08:00
committed by Alexandre Belloni
parent 04572d1892
commit 6b296dee3e
1 changed files with 9 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
drivers/rtc/rtc-nxp-bbnsm.c
View File

@@ -189,36 +189,26 @@ static int bbnsm_rtc_probe(struct platform_device *pdev)
/* clear all the pending events */ /* clear all the pending events */
regmap_write(bbnsm->regmap, BBNSM_EVENTS, 0x7A); regmap_write(bbnsm->regmap, BBNSM_EVENTS, 0x7A);
device_init_wakeup(&pdev->dev, true); ret = devm_device_init_wakeup(&pdev->dev);
dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq); if (ret)
dev_err(&pdev->dev, "failed to init wakeup, %d\n", ret);
ret = devm_pm_set_wake_irq(&pdev->dev, bbnsm->irq);
if (ret)
dev_err(&pdev->dev, "failed to set wake irq, %d\n", ret);
ret = devm_request_irq(&pdev->dev, bbnsm->irq, bbnsm_rtc_irq_handler, ret = devm_request_irq(&pdev->dev, bbnsm->irq, bbnsm_rtc_irq_handler,
IRQF_SHARED, "rtc alarm", &pdev->dev); IRQF_SHARED, "rtc alarm", &pdev->dev);
if (ret) { if (ret) {
dev_err(&pdev->dev, "failed to request irq %d: %d\n", dev_err(&pdev->dev, "failed to request irq %d: %d\n",
bbnsm->irq, ret); bbnsm->irq, ret);
goto err; return ret;
} }
bbnsm->rtc->ops = &bbnsm_rtc_ops; bbnsm->rtc->ops = &bbnsm_rtc_ops;
bbnsm->rtc->range_max = U32_MAX; bbnsm->rtc->range_max = U32_MAX;
ret = devm_rtc_register_device(bbnsm->rtc); return devm_rtc_register_device(bbnsm->rtc);
if (ret)
goto err;
return 0;
err:
dev_pm_clear_wake_irq(&pdev->dev);
device_init_wakeup(&pdev->dev, false);
return ret;
}
static void bbnsm_rtc_remove(struct platform_device *pdev)
{
dev_pm_clear_wake_irq(&pdev->dev);
device_init_wakeup(&pdev->dev, false);
} }
static const struct of_device_id bbnsm_dt_ids[] = { static const struct of_device_id bbnsm_dt_ids[] = {
@@ -233,7 +223,6 @@ static struct platform_driver bbnsm_rtc_driver = {
.of_match_table = bbnsm_dt_ids, .of_match_table = bbnsm_dt_ids,
}, },
.probe = bbnsm_rtc_probe, .probe = bbnsm_rtc_probe,
.remove = bbnsm_rtc_remove,
}; };
module_platform_driver(bbnsm_rtc_driver); module_platform_driver(bbnsm_rtc_driver);