git/linux-cryptodev-2.6
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git synced 2026-05-02 18:17:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

pwm: stm32: Remove clutter from ternary operator

Browse Source 
Remove usage of the ternary operator to assign values for register
fields. Instead, parameterize the register and field offset macros
and pass the index to them.

This removes clutter and improves readability.

Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
This commit is contained in:
Thierry Reding
2019-10-16 12:42:40 +02:00
parent 8dfa620e3d
commit 8e53622594
2 changed files with 13 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/pwm/pwm-stm32.c
View File

@@ -493,20 +493,17 @@ static const struct pwm_ops stm32pwm_ops = {
static int stm32_pwm_set_breakinput(struct stm32_pwm *priv,
int index, int level, int filter)
{
u32 bke = (index == 0) ? TIM_BDTR_BKE : TIM_BDTR_BK2E;
int shift = (index == 0) ? TIM_BDTR_BKF_SHIFT : TIM_BDTR_BK2F_SHIFT;
u32 mask = (index == 0) ? TIM_BDTR_BKE | TIM_BDTR_BKP | TIM_BDTR_BKF
: TIM_BDTR_BK2E | TIM_BDTR_BK2P | TIM_BDTR_BK2F;
u32 bdtr = bke;
u32 shift = TIM_BDTR_BKF_SHIFT(index);
u32 bke = TIM_BDTR_BKE(index);
u32 bkp = TIM_BDTR_BKP(index);
u32 bkf = TIM_BDTR_BKF(index);
u32 mask = bkf | bkp | bke;
u32 bdtr;
bdtr = (filter & TIM_BDTR_BKF_MASK) << shift | bke;
/*
* The both bits could be set since only one will be wrote
* due to mask value.
*/
if (level)
bdtr |= TIM_BDTR_BKP | TIM_BDTR_BK2P;
bdtr |= (filter & TIM_BDTR_BKF_MASK) << shift;
bdtr |= bkp;
regmap_update_bits(priv->regmap, TIM_BDTR, mask, bdtr);