mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
synced 2026-04-21 04:53:46 -04:00
hv_netvsc: Add a comment clarifying batching logic
The batching logic in netvsc_send is non-trivial, due to a combination of the Linux API and the underlying hypervisor interface. Add a comment explaining why the code is written this way. Signed-off-by: Shachar Raindel <shacharr@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Reviewed-by: Dexuan Cui <decui@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
0f88e6f35b
commit
bd49fea758
@@ -1017,6 +1017,26 @@ static inline void move_pkt_msd(struct hv_netvsc_packet **msd_send,
|
||||
}
|
||||
|
||||
/* RCU already held by caller */
|
||||
/* Batching/bouncing logic is designed to attempt to optimize
|
||||
* performance.
|
||||
*
|
||||
* For small, non-LSO packets we copy the packet to a send buffer
|
||||
* which is pre-registered with the Hyper-V side. This enables the
|
||||
* hypervisor to avoid remapping the aperture to access the packet
|
||||
* descriptor and data.
|
||||
*
|
||||
* If we already started using a buffer and the netdev is transmitting
|
||||
* a burst of packets, keep on copying into the buffer until it is
|
||||
* full or we are done collecting a burst. If there is an existing
|
||||
* buffer with space for the RNDIS descriptor but not the packet, copy
|
||||
* the RNDIS descriptor to the buffer, keeping the packet in place.
|
||||
*
|
||||
* If we do batching and send more than one packet using a single
|
||||
* NetVSC message, free the SKBs of the packets copied, except for the
|
||||
* last packet. This is done to streamline the handling of the case
|
||||
* where the last packet only had the RNDIS descriptor copied to the
|
||||
* send buffer, with the data pointers included in the NetVSC message.
|
||||
*/
|
||||
int netvsc_send(struct net_device *ndev,
|
||||
struct hv_netvsc_packet *packet,
|
||||
struct rndis_message *rndis_msg,
|
||||
|
||||
Reference in New Issue
Block a user