mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
synced 2026-04-27 11:58:32 -04:00
c60f91bbc4
Hotunplugging the device seems to result in stuff like: kobject_add_internal failed for tile0 with -EEXIST, don't try to register things with the same name in the same directory. We only remove the sysfs as part of drmm, however that is tied to the lifetime of the driver instance and not the device underneath. Attempt to fix by using devm for all of the remaining sysfs stuff related to the device. Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1667 Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1432 Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240522102143.128069-20-matthew.auld@intel.com
127 lines
3.0 KiB
C
127 lines
3.0 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright © 2024 Intel Corporation
|
|
*/
|
|
#include <linux/sysfs.h>
|
|
#include <drm/drm_managed.h>
|
|
|
|
#include "xe_gt_types.h"
|
|
#include "xe_pcode.h"
|
|
#include "xe_pcode_api.h"
|
|
#include "xe_tile.h"
|
|
#include "xe_tile_sysfs.h"
|
|
#include "xe_vram_freq.h"
|
|
|
|
/**
|
|
* DOC: Xe VRAM freq
|
|
*
|
|
* Provides sysfs entries for vram frequency in tile
|
|
*
|
|
* device/tile#/memory/freq0/max_freq - This is maximum frequency. This value is read-only as it
|
|
* is the fixed fuse point P0. It is not the system
|
|
* configuration.
|
|
* device/tile#/memory/freq0/min_freq - This is minimum frequency. This value is read-only as it
|
|
* is the fixed fuse point PN. It is not the system
|
|
* configuration.
|
|
*/
|
|
|
|
static struct xe_tile *dev_to_tile(struct device *dev)
|
|
{
|
|
return kobj_to_tile(dev->kobj.parent);
|
|
}
|
|
|
|
static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
struct xe_tile *tile = dev_to_tile(dev);
|
|
struct xe_gt *gt = tile->primary_gt;
|
|
u32 val, mbox;
|
|
int err;
|
|
|
|
mbox = REG_FIELD_PREP(PCODE_MB_COMMAND, PCODE_FREQUENCY_CONFIG)
|
|
| REG_FIELD_PREP(PCODE_MB_PARAM1, PCODE_MBOX_FC_SC_READ_FUSED_P0)
|
|
| REG_FIELD_PREP(PCODE_MB_PARAM2, PCODE_MBOX_DOMAIN_HBM);
|
|
|
|
err = xe_pcode_read(gt, mbox, &val, NULL);
|
|
if (err)
|
|
return err;
|
|
|
|
/* data_out - Fused P0 for domain ID in units of 50 MHz */
|
|
val *= 50;
|
|
|
|
return sysfs_emit(buf, "%u\n", val);
|
|
}
|
|
static DEVICE_ATTR_RO(max_freq);
|
|
|
|
static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
struct xe_tile *tile = dev_to_tile(dev);
|
|
struct xe_gt *gt = tile->primary_gt;
|
|
u32 val, mbox;
|
|
int err;
|
|
|
|
mbox = REG_FIELD_PREP(PCODE_MB_COMMAND, PCODE_FREQUENCY_CONFIG)
|
|
| REG_FIELD_PREP(PCODE_MB_PARAM1, PCODE_MBOX_FC_SC_READ_FUSED_PN)
|
|
| REG_FIELD_PREP(PCODE_MB_PARAM2, PCODE_MBOX_DOMAIN_HBM);
|
|
|
|
err = xe_pcode_read(gt, mbox, &val, NULL);
|
|
if (err)
|
|
return err;
|
|
|
|
/* data_out - Fused Pn for domain ID in units of 50 MHz */
|
|
val *= 50;
|
|
|
|
return sysfs_emit(buf, "%u\n", val);
|
|
}
|
|
static DEVICE_ATTR_RO(min_freq);
|
|
|
|
static struct attribute *freq_attrs[] = {
|
|
&dev_attr_max_freq.attr,
|
|
&dev_attr_min_freq.attr,
|
|
NULL
|
|
};
|
|
|
|
static const struct attribute_group freq_group_attrs = {
|
|
.name = "freq0",
|
|
.attrs = freq_attrs,
|
|
};
|
|
|
|
static void vram_freq_sysfs_fini(void *arg)
|
|
{
|
|
struct kobject *kobj = arg;
|
|
|
|
sysfs_remove_group(kobj, &freq_group_attrs);
|
|
kobject_put(kobj);
|
|
}
|
|
|
|
/**
|
|
* xe_vram_freq_sysfs_init - Initialize vram frequency sysfs component
|
|
* @tile: Xe Tile object
|
|
*
|
|
* It needs to be initialized after the main tile component is ready
|
|
*
|
|
* Returns: 0 on success, negative error code on error.
|
|
*/
|
|
int xe_vram_freq_sysfs_init(struct xe_tile *tile)
|
|
{
|
|
struct xe_device *xe = tile_to_xe(tile);
|
|
struct kobject *kobj;
|
|
int err;
|
|
|
|
if (xe->info.platform != XE_PVC)
|
|
return 0;
|
|
|
|
kobj = kobject_create_and_add("memory", tile->sysfs);
|
|
if (!kobj)
|
|
return -ENOMEM;
|
|
|
|
err = sysfs_create_group(kobj, &freq_group_attrs);
|
|
if (err) {
|
|
kobject_put(kobj);
|
|
return err;
|
|
}
|
|
|
|
return devm_add_action_or_reset(xe->drm.dev, vram_freq_sysfs_fini, kobj);
|
|
}
|