mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
synced 2026-04-21 04:53:46 -04:00
c886343397
The check whether GuC ABI version meets requirements shall be
performed after said version is received from GuC.
Doing it in wrong order was triggering a warning:
xe 0000:00:02.1: [drm] Assertion `gt->sriov.vf.guc_version.major` failed!
With this change, dislodge part of the VF migration support check
and moved it to after GuC handshake.
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Tested-by: Matthew Brost <matthew.brost@intel.com> #v1
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/6349
Fixes: ff1d2b5e3d ("drm/xe: Read VF GMD_ID with a specifically-allocated dummy GT")
Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Link: https://lore.kernel.org/r/20251021224817.1593817-3-tomasz.lis@intel.com
481 lines
17 KiB
C
481 lines
17 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright © 2025 Intel Corporation
|
|
*/
|
|
|
|
#include "instructions/xe_mi_commands.h"
|
|
#include "instructions/xe_gpu_commands.h"
|
|
#include "xe_bb.h"
|
|
#include "xe_bo.h"
|
|
#include "xe_device.h"
|
|
#include "xe_exec_queue.h"
|
|
#include "xe_exec_queue_types.h"
|
|
#include "xe_gt_sriov_vf.h"
|
|
#include "xe_guc.h"
|
|
#include "xe_guc_submit.h"
|
|
#include "xe_lrc.h"
|
|
#include "xe_migrate.h"
|
|
#include "xe_pm.h"
|
|
#include "xe_sa.h"
|
|
#include "xe_sriov_printk.h"
|
|
#include "xe_sriov_vf.h"
|
|
#include "xe_sriov_vf_ccs.h"
|
|
#include "xe_sriov_vf_ccs_types.h"
|
|
|
|
/**
|
|
* DOC: VF save/restore of compression Meta Data
|
|
*
|
|
* VF KMD registers two special contexts/LRCAs.
|
|
*
|
|
* Save Context/LRCA: contain necessary cmds+page table to trigger Meta data /
|
|
* compression control surface (Aka CCS) save in regular System memory in VM.
|
|
*
|
|
* Restore Context/LRCA: contain necessary cmds+page table to trigger Meta data /
|
|
* compression control surface (Aka CCS) Restore from regular System memory in
|
|
* VM to corresponding CCS pool.
|
|
*
|
|
* Below diagram explain steps needed for VF save/Restore of compression Meta Data::
|
|
*
|
|
* CCS Save CCS Restore VF KMD Guc BCS
|
|
* LRCA LRCA
|
|
* | | | | |
|
|
* | | | | |
|
|
* | Create Save LRCA | | |
|
|
* [ ]<----------------------------- [ ] | |
|
|
* | | | | |
|
|
* | | | | |
|
|
* | | | Register save LRCA | |
|
|
* | | | with Guc | |
|
|
* | | [ ]--------------------------->[ ] |
|
|
* | | | | |
|
|
* | | Create restore LRCA | | |
|
|
* | [ ]<------------------[ ] | |
|
|
* | | | | |
|
|
* | | | Register restore LRCA | |
|
|
* | | | with Guc | |
|
|
* | | [ ]--------------------------->[ ] |
|
|
* | | | | |
|
|
* | | | | |
|
|
* | | [ ]------------------------- | |
|
|
* | | [ ] Allocate main memory. | | |
|
|
* | | [ ] Allocate CCS memory. | | |
|
|
* | | [ ] Update Main memory & | | |
|
|
* [ ]<------------------------------[ ] CCS pages PPGTT + BB | | |
|
|
* | [ ]<------------------[ ] cmds to save & restore.| | |
|
|
* | | [ ]<------------------------ | |
|
|
* | | | | |
|
|
* | | | | |
|
|
* | | | | |
|
|
* : : : : :
|
|
* ---------------------------- VF Paused -------------------------------------
|
|
* | | | | |
|
|
* | | | | |
|
|
* | | | |Schedule |
|
|
* | | | |CCS Save |
|
|
* | | | | LRCA |
|
|
* | | | [ ]------>[ ]
|
|
* | | | | |
|
|
* | | | | |
|
|
* | | | |CCS save |
|
|
* | | | |completed|
|
|
* | | | [ ]<------[ ]
|
|
* | | | | |
|
|
* : : : : :
|
|
* ---------------------------- VM Migrated -----------------------------------
|
|
* | | | | |
|
|
* | | | | |
|
|
* : : : : :
|
|
* ---------------------------- VF Resumed ------------------------------------
|
|
* | | | | |
|
|
* | | | | |
|
|
* | | [ ]-------------- | |
|
|
* | | [ ] Fix up GGTT | | |
|
|
* | | [ ]<------------- | |
|
|
* | | | | |
|
|
* | | | | |
|
|
* | | | Notify VF_RESFIX_DONE | |
|
|
* | | [ ]--------------------------->[ ] |
|
|
* | | | | |
|
|
* | | | |Schedule |
|
|
* | | | |CCS |
|
|
* | | | |Restore |
|
|
* | | | |LRCA |
|
|
* | | | [ ]------>[ ]
|
|
* | | | | |
|
|
* | | | | |
|
|
* | | | |CCS |
|
|
* | | | |restore |
|
|
* | | | |completed|
|
|
* | | | [ ]<------[ ]
|
|
* | | | | |
|
|
* | | | | |
|
|
* | | | VF_RESFIX_DONE complete | |
|
|
* | | | notification | |
|
|
* | | [ ]<---------------------------[ ] |
|
|
* | | | | |
|
|
* | | | | |
|
|
* : : : : :
|
|
* ------------------------- Continue VM restore ------------------------------
|
|
*/
|
|
|
|
static u64 get_ccs_bb_pool_size(struct xe_device *xe)
|
|
{
|
|
u64 sys_mem_size, ccs_mem_size, ptes, bb_pool_size;
|
|
struct sysinfo si;
|
|
|
|
si_meminfo(&si);
|
|
sys_mem_size = si.totalram * si.mem_unit;
|
|
ccs_mem_size = div64_u64(sys_mem_size, NUM_BYTES_PER_CCS_BYTE(xe));
|
|
ptes = DIV_ROUND_UP_ULL(sys_mem_size + ccs_mem_size, XE_PAGE_SIZE);
|
|
|
|
/**
|
|
* We need below BB size to hold PTE mappings and some DWs for copy
|
|
* command. In reality, we need space for many copy commands. So, let
|
|
* us allocate double the calculated size which is enough to holds GPU
|
|
* instructions for the whole region.
|
|
*/
|
|
bb_pool_size = ptes * sizeof(u32);
|
|
|
|
return round_up(bb_pool_size * 2, SZ_1M);
|
|
}
|
|
|
|
static int alloc_bb_pool(struct xe_tile *tile, struct xe_sriov_vf_ccs_ctx *ctx)
|
|
{
|
|
struct xe_device *xe = tile_to_xe(tile);
|
|
struct xe_sa_manager *sa_manager;
|
|
u64 bb_pool_size;
|
|
int offset, err;
|
|
|
|
bb_pool_size = get_ccs_bb_pool_size(xe);
|
|
xe_sriov_info(xe, "Allocating %s CCS BB pool size = %lldMB\n",
|
|
ctx->ctx_id ? "Restore" : "Save", bb_pool_size / SZ_1M);
|
|
|
|
sa_manager = xe_sa_bo_manager_init(tile, bb_pool_size, SZ_16);
|
|
|
|
if (IS_ERR(sa_manager)) {
|
|
xe_sriov_err(xe, "Suballocator init failed with error: %pe\n",
|
|
sa_manager);
|
|
err = PTR_ERR(sa_manager);
|
|
return err;
|
|
}
|
|
|
|
offset = 0;
|
|
xe_map_memset(xe, &sa_manager->bo->vmap, offset, MI_NOOP,
|
|
bb_pool_size);
|
|
|
|
offset = bb_pool_size - sizeof(u32);
|
|
xe_map_wr(xe, &sa_manager->bo->vmap, offset, u32, MI_BATCH_BUFFER_END);
|
|
|
|
ctx->mem.ccs_bb_pool = sa_manager;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void ccs_rw_update_ring(struct xe_sriov_vf_ccs_ctx *ctx)
|
|
{
|
|
u64 addr = xe_sa_manager_gpu_addr(ctx->mem.ccs_bb_pool);
|
|
struct xe_lrc *lrc = xe_exec_queue_lrc(ctx->mig_q);
|
|
u32 dw[10], i = 0;
|
|
|
|
/*
|
|
* XXX: Save/restore fixes — for some reason, the GuC only accepts the
|
|
* save/restore context if the LRC head pointer is zero. This is evident
|
|
* from repeated VF migrations failing when the LRC head pointer is
|
|
* non-zero.
|
|
*/
|
|
lrc->ring.tail = 0;
|
|
xe_lrc_set_ring_head(lrc, 0);
|
|
|
|
dw[i++] = MI_ARB_ON_OFF | MI_ARB_ENABLE;
|
|
dw[i++] = MI_BATCH_BUFFER_START | XE_INSTR_NUM_DW(3);
|
|
dw[i++] = lower_32_bits(addr);
|
|
dw[i++] = upper_32_bits(addr);
|
|
dw[i++] = MI_NOOP;
|
|
dw[i++] = MI_NOOP;
|
|
|
|
xe_lrc_write_ring(lrc, dw, i * sizeof(u32));
|
|
xe_lrc_set_ring_tail(lrc, lrc->ring.tail);
|
|
}
|
|
|
|
/**
|
|
* xe_sriov_vf_ccs_rebase - Rebase GGTT addresses for CCS save / restore
|
|
* @xe: the &xe_device.
|
|
*/
|
|
void xe_sriov_vf_ccs_rebase(struct xe_device *xe)
|
|
{
|
|
enum xe_sriov_vf_ccs_rw_ctxs ctx_id;
|
|
|
|
if (!IS_VF_CCS_READY(xe))
|
|
return;
|
|
|
|
for_each_ccs_rw_ctx(ctx_id) {
|
|
struct xe_sriov_vf_ccs_ctx *ctx =
|
|
&xe->sriov.vf.ccs.contexts[ctx_id];
|
|
|
|
ccs_rw_update_ring(ctx);
|
|
}
|
|
}
|
|
|
|
static int register_save_restore_context(struct xe_sriov_vf_ccs_ctx *ctx)
|
|
{
|
|
int ctx_type;
|
|
|
|
switch (ctx->ctx_id) {
|
|
case XE_SRIOV_VF_CCS_READ_CTX:
|
|
ctx_type = GUC_CONTEXT_COMPRESSION_SAVE;
|
|
break;
|
|
case XE_SRIOV_VF_CCS_WRITE_CTX:
|
|
ctx_type = GUC_CONTEXT_COMPRESSION_RESTORE;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
|
|
xe_guc_register_vf_exec_queue(ctx->mig_q, ctx_type);
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* xe_sriov_vf_ccs_register_context - Register read/write contexts with guc.
|
|
* @xe: the &xe_device to register contexts on.
|
|
*
|
|
* This function registers read and write contexts with Guc. Re-registration
|
|
* is needed whenever resuming from pm runtime suspend.
|
|
*
|
|
* Return: 0 on success. Negative error code on failure.
|
|
*/
|
|
int xe_sriov_vf_ccs_register_context(struct xe_device *xe)
|
|
{
|
|
enum xe_sriov_vf_ccs_rw_ctxs ctx_id;
|
|
struct xe_sriov_vf_ccs_ctx *ctx;
|
|
int err;
|
|
|
|
xe_assert(xe, IS_VF_CCS_READY(xe));
|
|
|
|
for_each_ccs_rw_ctx(ctx_id) {
|
|
ctx = &xe->sriov.vf.ccs.contexts[ctx_id];
|
|
err = register_save_restore_context(ctx);
|
|
if (err)
|
|
return err;
|
|
}
|
|
|
|
return err;
|
|
}
|
|
|
|
/*
|
|
* Whether GuC requires CCS copy BBs for VF migration.
|
|
* @xe: the &xe_device instance.
|
|
*
|
|
* Only selected platforms require VF KMD to maintain CCS copy BBs and linked LRCAs.
|
|
*
|
|
* Return: true if VF driver must participate in the CCS migration, false otherwise.
|
|
*/
|
|
static bool vf_migration_ccs_bb_needed(struct xe_device *xe)
|
|
{
|
|
xe_assert(xe, IS_SRIOV_VF(xe));
|
|
|
|
return !IS_DGFX(xe) && xe_device_has_flat_ccs(xe);
|
|
}
|
|
|
|
/*
|
|
* Check for disable migration due to no CCS BBs support in GuC FW.
|
|
* @xe: the &xe_device instance.
|
|
*
|
|
* Performs late disable of VF migration feature in case GuC FW cannot support it.
|
|
*
|
|
* Returns: True if VF migration with CCS BBs is supported, false otherwise.
|
|
*/
|
|
static bool vf_migration_ccs_bb_support_check(struct xe_device *xe)
|
|
{
|
|
struct xe_gt *gt = xe_root_mmio_gt(xe);
|
|
struct xe_uc_fw_version guc_version;
|
|
|
|
xe_gt_sriov_vf_guc_versions(gt, NULL, &guc_version);
|
|
if (MAKE_GUC_VER_STRUCT(guc_version) < MAKE_GUC_VER(1, 23, 0)) {
|
|
xe_sriov_vf_migration_disable(xe,
|
|
"CCS migration requires GuC ABI >= 1.23 but only %u.%u found",
|
|
guc_version.major, guc_version.minor);
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
static void xe_sriov_vf_ccs_fini(void *arg)
|
|
{
|
|
struct xe_sriov_vf_ccs_ctx *ctx = arg;
|
|
struct xe_lrc *lrc = xe_exec_queue_lrc(ctx->mig_q);
|
|
|
|
/*
|
|
* Make TAIL = HEAD in the ring so that no issues are seen if Guc
|
|
* submits this context to HW on VF pause after unbinding device.
|
|
*/
|
|
xe_lrc_set_ring_tail(lrc, xe_lrc_ring_head(lrc));
|
|
xe_exec_queue_put(ctx->mig_q);
|
|
}
|
|
|
|
/**
|
|
* xe_sriov_vf_ccs_init - Setup LRCA for save & restore.
|
|
* @xe: the &xe_device to start recovery on
|
|
*
|
|
* This function shall be called only by VF. It initializes
|
|
* LRCA and suballocator needed for CCS save & restore.
|
|
*
|
|
* Return: 0 on success. Negative error code on failure.
|
|
*/
|
|
int xe_sriov_vf_ccs_init(struct xe_device *xe)
|
|
{
|
|
struct xe_tile *tile = xe_device_get_root_tile(xe);
|
|
enum xe_sriov_vf_ccs_rw_ctxs ctx_id;
|
|
struct xe_sriov_vf_ccs_ctx *ctx;
|
|
struct xe_exec_queue *q;
|
|
u32 flags;
|
|
int err;
|
|
|
|
xe_assert(xe, IS_SRIOV_VF(xe));
|
|
|
|
if (!xe_sriov_vf_migration_supported(xe) ||
|
|
!vf_migration_ccs_bb_needed(xe) ||
|
|
!vf_migration_ccs_bb_support_check(xe))
|
|
return 0;
|
|
|
|
for_each_ccs_rw_ctx(ctx_id) {
|
|
ctx = &xe->sriov.vf.ccs.contexts[ctx_id];
|
|
ctx->ctx_id = ctx_id;
|
|
|
|
flags = EXEC_QUEUE_FLAG_KERNEL |
|
|
EXEC_QUEUE_FLAG_PERMANENT |
|
|
EXEC_QUEUE_FLAG_MIGRATE;
|
|
q = xe_exec_queue_create_bind(xe, tile, flags, 0);
|
|
if (IS_ERR(q)) {
|
|
err = PTR_ERR(q);
|
|
goto err_ret;
|
|
}
|
|
ctx->mig_q = q;
|
|
|
|
err = alloc_bb_pool(tile, ctx);
|
|
if (err)
|
|
goto err_free_queue;
|
|
|
|
ccs_rw_update_ring(ctx);
|
|
|
|
err = register_save_restore_context(ctx);
|
|
if (err)
|
|
goto err_free_queue;
|
|
|
|
err = devm_add_action_or_reset(xe->drm.dev,
|
|
xe_sriov_vf_ccs_fini,
|
|
ctx);
|
|
if (err)
|
|
goto err_ret;
|
|
}
|
|
|
|
xe->sriov.vf.ccs.initialized = 1;
|
|
|
|
return 0;
|
|
|
|
err_free_queue:
|
|
xe_exec_queue_put(q);
|
|
|
|
err_ret:
|
|
return err;
|
|
}
|
|
|
|
/**
|
|
* xe_sriov_vf_ccs_attach_bo - Insert CCS read write commands in the BO.
|
|
* @bo: the &buffer object to which batch buffer commands will be added.
|
|
*
|
|
* This function shall be called only by VF. It inserts the PTEs and copy
|
|
* command instructions in the BO by calling xe_migrate_ccs_rw_copy()
|
|
* function.
|
|
*
|
|
* Returns: 0 if successful, negative error code on failure.
|
|
*/
|
|
int xe_sriov_vf_ccs_attach_bo(struct xe_bo *bo)
|
|
{
|
|
struct xe_device *xe = xe_bo_device(bo);
|
|
enum xe_sriov_vf_ccs_rw_ctxs ctx_id;
|
|
struct xe_sriov_vf_ccs_ctx *ctx;
|
|
struct xe_tile *tile;
|
|
struct xe_bb *bb;
|
|
int err = 0;
|
|
|
|
xe_assert(xe, IS_VF_CCS_READY(xe));
|
|
|
|
tile = xe_device_get_root_tile(xe);
|
|
|
|
for_each_ccs_rw_ctx(ctx_id) {
|
|
bb = bo->bb_ccs[ctx_id];
|
|
/* bb should be NULL here. Assert if not NULL */
|
|
xe_assert(xe, !bb);
|
|
|
|
ctx = &xe->sriov.vf.ccs.contexts[ctx_id];
|
|
err = xe_migrate_ccs_rw_copy(tile, ctx->mig_q, bo, ctx_id);
|
|
}
|
|
return err;
|
|
}
|
|
|
|
/**
|
|
* xe_sriov_vf_ccs_detach_bo - Remove CCS read write commands from the BO.
|
|
* @bo: the &buffer object from which batch buffer commands will be removed.
|
|
*
|
|
* This function shall be called only by VF. It removes the PTEs and copy
|
|
* command instructions from the BO. Make sure to update the BB with MI_NOOP
|
|
* before freeing.
|
|
*
|
|
* Returns: 0 if successful.
|
|
*/
|
|
int xe_sriov_vf_ccs_detach_bo(struct xe_bo *bo)
|
|
{
|
|
struct xe_device *xe = xe_bo_device(bo);
|
|
enum xe_sriov_vf_ccs_rw_ctxs ctx_id;
|
|
struct xe_bb *bb;
|
|
|
|
xe_assert(xe, IS_VF_CCS_READY(xe));
|
|
|
|
if (!xe_bo_has_valid_ccs_bb(bo))
|
|
return 0;
|
|
|
|
for_each_ccs_rw_ctx(ctx_id) {
|
|
bb = bo->bb_ccs[ctx_id];
|
|
if (!bb)
|
|
continue;
|
|
|
|
memset(bb->cs, MI_NOOP, bb->len * sizeof(u32));
|
|
xe_bb_free(bb, NULL);
|
|
bo->bb_ccs[ctx_id] = NULL;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* xe_sriov_vf_ccs_print - Print VF CCS details.
|
|
* @xe: the &xe_device
|
|
* @p: the &drm_printer
|
|
*
|
|
* This function is for VF use only.
|
|
*/
|
|
void xe_sriov_vf_ccs_print(struct xe_device *xe, struct drm_printer *p)
|
|
{
|
|
struct xe_sa_manager *bb_pool;
|
|
enum xe_sriov_vf_ccs_rw_ctxs ctx_id;
|
|
|
|
if (!IS_VF_CCS_READY(xe))
|
|
return;
|
|
|
|
xe_pm_runtime_get(xe);
|
|
|
|
for_each_ccs_rw_ctx(ctx_id) {
|
|
bb_pool = xe->sriov.vf.ccs.contexts[ctx_id].mem.ccs_bb_pool;
|
|
if (!bb_pool)
|
|
break;
|
|
|
|
drm_printf(p, "ccs %s bb suballoc info\n", ctx_id ? "write" : "read");
|
|
drm_printf(p, "-------------------------\n");
|
|
drm_suballoc_dump_debug_info(&bb_pool->base, p, xe_sa_manager_gpu_addr(bb_pool));
|
|
drm_puts(p, "\n");
|
|
}
|
|
|
|
xe_pm_runtime_put(xe);
|
|
}
|