mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
synced 2026-04-18 03:23:53 -04:00
36b0562922
Some platforms expose reboot mode cells that are smaller than an
unsigned int, in which cases lead to write failures. Read the cell
first to determine actual size and only write the number of bytes the
cell can hold.
Fixes: 7a78a7f769 ("power: reset: nvmem-reboot-mode: use NVMEM as reboot mode write interface")
Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
Link: https://patch.msgid.link/20251214191529.2470580-1-akoskovich@pm.me
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
88 lines
2.1 KiB
C
88 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (c) Vaisala Oyj. All rights reserved.
|
|
*/
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/of.h>
|
|
#include <linux/nvmem-consumer.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/reboot-mode.h>
|
|
#include <linux/slab.h>
|
|
|
|
struct nvmem_reboot_mode {
|
|
struct reboot_mode_driver reboot;
|
|
struct nvmem_cell *cell;
|
|
};
|
|
|
|
static int nvmem_reboot_mode_write(struct reboot_mode_driver *reboot,
|
|
unsigned int magic)
|
|
{
|
|
struct nvmem_reboot_mode *nvmem_rbm;
|
|
size_t buf_len;
|
|
void *buf;
|
|
int ret;
|
|
|
|
nvmem_rbm = container_of(reboot, struct nvmem_reboot_mode, reboot);
|
|
|
|
buf = nvmem_cell_read(nvmem_rbm->cell, &buf_len);
|
|
if (IS_ERR(buf))
|
|
return PTR_ERR(buf);
|
|
kfree(buf);
|
|
|
|
if (buf_len > sizeof(magic))
|
|
return -EINVAL;
|
|
|
|
ret = nvmem_cell_write(nvmem_rbm->cell, &magic, buf_len);
|
|
if (ret < 0)
|
|
dev_err(reboot->dev, "update reboot mode bits failed\n");
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int nvmem_reboot_mode_probe(struct platform_device *pdev)
|
|
{
|
|
int ret;
|
|
struct nvmem_reboot_mode *nvmem_rbm;
|
|
|
|
nvmem_rbm = devm_kzalloc(&pdev->dev, sizeof(*nvmem_rbm), GFP_KERNEL);
|
|
if (!nvmem_rbm)
|
|
return -ENOMEM;
|
|
|
|
nvmem_rbm->reboot.dev = &pdev->dev;
|
|
nvmem_rbm->reboot.write = nvmem_reboot_mode_write;
|
|
|
|
nvmem_rbm->cell = devm_nvmem_cell_get(&pdev->dev, "reboot-mode");
|
|
if (IS_ERR(nvmem_rbm->cell)) {
|
|
return dev_err_probe(&pdev->dev, PTR_ERR(nvmem_rbm->cell),
|
|
"failed to get the nvmem cell reboot-mode\n");
|
|
}
|
|
|
|
ret = devm_reboot_mode_register(&pdev->dev, &nvmem_rbm->reboot);
|
|
if (ret)
|
|
dev_err(&pdev->dev, "can't register reboot mode\n");
|
|
|
|
return ret;
|
|
}
|
|
|
|
static const struct of_device_id nvmem_reboot_mode_of_match[] = {
|
|
{ .compatible = "nvmem-reboot-mode" },
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(of, nvmem_reboot_mode_of_match);
|
|
|
|
static struct platform_driver nvmem_reboot_mode_driver = {
|
|
.probe = nvmem_reboot_mode_probe,
|
|
.driver = {
|
|
.name = "nvmem-reboot-mode",
|
|
.of_match_table = nvmem_reboot_mode_of_match,
|
|
},
|
|
};
|
|
module_platform_driver(nvmem_reboot_mode_driver);
|
|
|
|
MODULE_AUTHOR("Nandor Han <nandor.han@vaisala.com>");
|
|
MODULE_DESCRIPTION("NVMEM reboot mode driver");
|
|
MODULE_LICENSE("GPL");
|