mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
synced 2026-04-19 12:03:56 -04:00
30b981796b
Make sure kernel doesn't respond to GETs for queues and NAPIs when link is down. Not with valid data, or with empty message, we want a ENOENT. Link: https://patch.msgid.link/20241219032833.1165433-2-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
90 lines
2.6 KiB
Python
Executable File
90 lines
2.6 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
from lib.py import ksft_disruptive, ksft_exit, ksft_run
|
|
from lib.py import ksft_eq, ksft_raises, KsftSkipEx
|
|
from lib.py import EthtoolFamily, NetdevFamily, NlError
|
|
from lib.py import NetDrvEnv
|
|
from lib.py import cmd, defer, ip
|
|
import errno
|
|
import glob
|
|
|
|
|
|
def sys_get_queues(ifname, qtype='rx') -> int:
|
|
folders = glob.glob(f'/sys/class/net/{ifname}/queues/{qtype}-*')
|
|
return len(folders)
|
|
|
|
|
|
def nl_get_queues(cfg, nl, qtype='rx'):
|
|
queues = nl.queue_get({'ifindex': cfg.ifindex}, dump=True)
|
|
if queues:
|
|
return len([q for q in queues if q['type'] == qtype])
|
|
return None
|
|
|
|
|
|
def get_queues(cfg, nl) -> None:
|
|
snl = NetdevFamily(recv_size=4096)
|
|
|
|
for qtype in ['rx', 'tx']:
|
|
queues = nl_get_queues(cfg, snl, qtype)
|
|
if not queues:
|
|
raise KsftSkipEx('queue-get not supported by device')
|
|
|
|
expected = sys_get_queues(cfg.dev['ifname'], qtype)
|
|
ksft_eq(queues, expected)
|
|
|
|
|
|
def addremove_queues(cfg, nl) -> None:
|
|
queues = nl_get_queues(cfg, nl)
|
|
if not queues:
|
|
raise KsftSkipEx('queue-get not supported by device')
|
|
|
|
curr_queues = sys_get_queues(cfg.dev['ifname'])
|
|
if curr_queues == 1:
|
|
raise KsftSkipEx('cannot decrement queue: already at 1')
|
|
|
|
netnl = EthtoolFamily()
|
|
channels = netnl.channels_get({'header': {'dev-index': cfg.ifindex}})
|
|
if channels['combined-count'] == 0:
|
|
rx_type = 'rx'
|
|
else:
|
|
rx_type = 'combined'
|
|
|
|
expected = curr_queues - 1
|
|
cmd(f"ethtool -L {cfg.dev['ifname']} {rx_type} {expected}", timeout=10)
|
|
queues = nl_get_queues(cfg, nl)
|
|
ksft_eq(queues, expected)
|
|
|
|
expected = curr_queues
|
|
cmd(f"ethtool -L {cfg.dev['ifname']} {rx_type} {expected}", timeout=10)
|
|
queues = nl_get_queues(cfg, nl)
|
|
ksft_eq(queues, expected)
|
|
|
|
|
|
@ksft_disruptive
|
|
def check_down(cfg, nl) -> None:
|
|
# Check the NAPI IDs before interface goes down and hides them
|
|
napis = nl.napi_get({'ifindex': cfg.ifindex}, dump=True)
|
|
|
|
ip(f"link set dev {cfg.dev['ifname']} down")
|
|
defer(ip, f"link set dev {cfg.dev['ifname']} up")
|
|
|
|
with ksft_raises(NlError) as cm:
|
|
nl.queue_get({'ifindex': cfg.ifindex, 'id': 0, 'type': 'rx'})
|
|
ksft_eq(cm.exception.nl_msg.error, -errno.ENOENT)
|
|
|
|
if napis:
|
|
with ksft_raises(NlError) as cm:
|
|
nl.napi_get({'id': napis[0]['id']})
|
|
ksft_eq(cm.exception.nl_msg.error, -errno.ENOENT)
|
|
|
|
|
|
def main() -> None:
|
|
with NetDrvEnv(__file__, queue_count=100) as cfg:
|
|
ksft_run([get_queues, addremove_queues, check_down], args=(cfg, NetdevFamily()))
|
|
ksft_exit()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|