mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
synced 2026-04-18 03:23:53 -04:00
vsprintf() performs no bounds checking and can overflow - replace it
with the safer vsnprintf().
Also remove the useless '+ 1' that is a leftover of commit 66ed28ea09
("m68k: sun3: Remove unused vsprintf() return value in prom_printf()").
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://patch.msgid.link/20260117202152.1036278-2-thorsten.blum@linux.dev
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
56 lines
975 B
C
56 lines
975 B
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* printf.c: Internal prom library printf facility.
|
|
*
|
|
* Copyright (C) 1995 David S. Miller (davem@caip.rutgers.edu)
|
|
*/
|
|
|
|
/* This routine is internal to the prom library, no one else should know
|
|
* about or use it! It's simple and smelly anyway....
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <asm/openprom.h>
|
|
#include <asm/oplib.h>
|
|
|
|
#ifdef CONFIG_KGDB
|
|
extern int kgdb_initialized;
|
|
#endif
|
|
|
|
static char ppbuf[1024];
|
|
|
|
void
|
|
prom_printf(char *fmt, ...)
|
|
{
|
|
va_list args;
|
|
char ch, *bptr;
|
|
|
|
va_start(args, fmt);
|
|
|
|
#ifdef CONFIG_KGDB
|
|
ppbuf[0] = 'O';
|
|
vsnprintf(ppbuf + 1, sizeof(ppbuf) - 1, fmt, args);
|
|
#else
|
|
vsnprintf(ppbuf, sizeof(ppbuf), fmt, args);
|
|
#endif
|
|
|
|
bptr = ppbuf;
|
|
|
|
#ifdef CONFIG_KGDB
|
|
if (kgdb_initialized) {
|
|
pr_info("kgdb_initialized = %d\n", kgdb_initialized);
|
|
putpacket(bptr, 1);
|
|
} else
|
|
#else
|
|
while((ch = *(bptr++)) != 0) {
|
|
if(ch == '\n')
|
|
prom_putchar('\r');
|
|
|
|
prom_putchar(ch);
|
|
}
|
|
#endif
|
|
va_end(args);
|
|
return;
|
|
}
|