mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
synced 2026-04-04 20:57:45 -04:00
A DABT is reported[1] on an android based system when resume from hiberate. This happens because swsusp_arch_suspend_exit() is marked with SYM_CODE_*() and does not have a CFI hash, but swsusp_arch_resume() will attempt to verify the CFI hash when calling a copy of swsusp_arch_suspend_exit(). Given that there's an existing requirement that the entrypoint to swsusp_arch_suspend_exit() is the first byte of the .hibernate_exit.text section, we cannot fix this by marking swsusp_arch_suspend_exit() with SYM_FUNC_*(). The simplest fix for now is to disable the CFI check in swsusp_arch_resume(). Mark swsusp_arch_resume() as __nocfi to disable the CFI check. [1] [ 22.991934][ T1] Unable to handle kernel paging request at virtual address 0000000109170ffc [ 22.991934][ T1] Mem abort info: [ 22.991934][ T1] ESR = 0x0000000096000007 [ 22.991934][ T1] EC = 0x25: DABT (current EL), IL = 32 bits [ 22.991934][ T1] SET = 0, FnV = 0 [ 22.991934][ T1] EA = 0, S1PTW = 0 [ 22.991934][ T1] FSC = 0x07: level 3 translation fault [ 22.991934][ T1] Data abort info: [ 22.991934][ T1] ISV = 0, ISS = 0x00000007, ISS2 = 0x00000000 [ 22.991934][ T1] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [ 22.991934][ T1] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [ 22.991934][ T1] [0000000109170ffc] user address but active_mm is swapper [ 22.991934][ T1] Internal error: Oops: 0000000096000007 [#1] PREEMPT SMP [ 22.991934][ T1] Dumping ftrace buffer: [ 22.991934][ T1] (ftrace buffer empty) [ 22.991934][ T1] Modules linked in: [ 22.991934][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.6.98-android15-8-g0b1d2aee7fc3-dirty-4k #1 688c7060a825a3ac418fe53881730b355915a419 [ 22.991934][ T1] Hardware name: Unisoc UMS9360-base Board (DT) [ 22.991934][ T1] pstate: 804000c5 (Nzcv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 22.991934][ T1] pc : swsusp_arch_resume+0x2ac/0x344 [ 22.991934][ T1] lr : swsusp_arch_resume+0x294/0x344 [ 22.991934][ T1] sp : ffffffc08006b960 [ 22.991934][ T1] x29: ffffffc08006b9c0 x28: 0000000000000000 x27: 0000000000000000 [ 22.991934][ T1] x26: 0000000000000000 x25: 0000000000000000 x24: 0000000000000820 [ 22.991934][ T1] x23: ffffffd0817e3000 x22: ffffffd0817e3000 x21: 0000000000000000 [ 22.991934][ T1] x20: ffffff8089171000 x19: ffffffd08252c8c8 x18: ffffffc080061058 [ 22.991934][ T1] x17: 00000000529c6ef0 x16: 00000000529c6ef0 x15: 0000000000000004 [ 22.991934][ T1] x14: ffffff8178c88000 x13: 0000000000000006 x12: 0000000000000000 [ 22.991934][ T1] x11: 0000000000000015 x10: 0000000000000001 x9 : ffffffd082533000 [ 22.991934][ T1] x8 : 0000000109171000 x7 : 205b5d3433393139 x6 : 392e32322020205b [ 22.991934][ T1] x5 : 000000010916f000 x4 : 000000008164b000 x3 : ffffff808a4e0530 [ 22.991934][ T1] x2 : ffffffd08058e784 x1 : 0000000082326000 x0 : 000000010a283000 [ 22.991934][ T1] Call trace: [ 22.991934][ T1] swsusp_arch_resume+0x2ac/0x344 [ 22.991934][ T1] hibernation_restore+0x158/0x18c [ 22.991934][ T1] load_image_and_restore+0xb0/0xec [ 22.991934][ T1] software_resume+0xf4/0x19c [ 22.991934][ T1] software_resume_initcall+0x34/0x78 [ 22.991934][ T1] do_one_initcall+0xe8/0x370 [ 22.991934][ T1] do_initcall_level+0xc8/0x19c [ 22.991934][ T1] do_initcalls+0x70/0xc0 [ 22.991934][ T1] do_basic_setup+0x1c/0x28 [ 22.991934][ T1] kernel_init_freeable+0xe0/0x148 [ 22.991934][ T1] kernel_init+0x20/0x1a8 [ 22.991934][ T1] ret_from_fork+0x10/0x20 [ 22.991934][ T1] Code: a9400a61 f94013e0 f9438923 f9400a64 (b85fc110) Co-developed-by: Jeson Gao <jeson.gao@unisoc.com> Signed-off-by: Jeson Gao <jeson.gao@unisoc.com> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com> Acked-by: Will Deacon <will@kernel.org> Acked-by: Mark Rutland <mark.rutland@arm.com> Cc: <stable@vger.kernel.org> [catalin.marinas@arm.com: commit log updated by Mark Rutland] Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
484 lines
12 KiB
C
484 lines
12 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*:
|
|
* Hibernate support specific for ARM64
|
|
*
|
|
* Derived from work on ARM hibernation support by:
|
|
*
|
|
* Ubuntu project, hibernation support for mach-dove
|
|
* Copyright (C) 2010 Nokia Corporation (Hiroshi Doyu)
|
|
* Copyright (C) 2010 Texas Instruments, Inc. (Teerth Reddy et al.)
|
|
* Copyright (C) 2006 Rafael J. Wysocki <rjw@sisk.pl>
|
|
*/
|
|
#define pr_fmt(x) "hibernate: " x
|
|
#include <linux/cpu.h>
|
|
#include <linux/kvm_host.h>
|
|
#include <linux/pm.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/suspend.h>
|
|
#include <linux/utsname.h>
|
|
|
|
#include <asm/barrier.h>
|
|
#include <asm/cacheflush.h>
|
|
#include <asm/cputype.h>
|
|
#include <asm/daifflags.h>
|
|
#include <asm/irqflags.h>
|
|
#include <asm/kexec.h>
|
|
#include <asm/memory.h>
|
|
#include <asm/mmu_context.h>
|
|
#include <asm/mte.h>
|
|
#include <asm/sections.h>
|
|
#include <asm/smp.h>
|
|
#include <asm/smp_plat.h>
|
|
#include <asm/suspend.h>
|
|
#include <asm/sysreg.h>
|
|
#include <asm/trans_pgd.h>
|
|
#include <asm/virt.h>
|
|
|
|
/*
|
|
* Hibernate core relies on this value being 0 on resume, and marks it
|
|
* __nosavedata assuming it will keep the resume kernel's '0' value. This
|
|
* doesn't happen with either KASLR.
|
|
*
|
|
* defined as "__visible int in_suspend __nosavedata" in
|
|
* kernel/power/hibernate.c
|
|
*/
|
|
extern int in_suspend;
|
|
|
|
/* Do we need to reset el2? */
|
|
#define el2_reset_needed() (is_hyp_nvhe())
|
|
|
|
/* hyp-stub vectors, used to restore el2 during resume from hibernate. */
|
|
extern char __hyp_stub_vectors[];
|
|
|
|
/*
|
|
* The logical cpu number we should resume on, initialised to a non-cpu
|
|
* number.
|
|
*/
|
|
static int sleep_cpu = -EINVAL;
|
|
|
|
/*
|
|
* Values that may not change over hibernate/resume. We put the build number
|
|
* and date in here so that we guarantee not to resume with a different
|
|
* kernel.
|
|
*/
|
|
struct arch_hibernate_hdr_invariants {
|
|
char uts_version[__NEW_UTS_LEN + 1];
|
|
};
|
|
|
|
/* These values need to be know across a hibernate/restore. */
|
|
static struct arch_hibernate_hdr {
|
|
struct arch_hibernate_hdr_invariants invariants;
|
|
|
|
/* These are needed to find the relocated kernel if built with kaslr */
|
|
phys_addr_t ttbr1_el1;
|
|
void (*reenter_kernel)(void);
|
|
|
|
/*
|
|
* We need to know where the __hyp_stub_vectors are after restore to
|
|
* re-configure el2.
|
|
*/
|
|
phys_addr_t __hyp_stub_vectors;
|
|
|
|
u64 sleep_cpu_mpidr;
|
|
} resume_hdr;
|
|
|
|
static inline void arch_hdr_invariants(struct arch_hibernate_hdr_invariants *i)
|
|
{
|
|
memset(i, 0, sizeof(*i));
|
|
memcpy(i->uts_version, init_utsname()->version, sizeof(i->uts_version));
|
|
}
|
|
|
|
int pfn_is_nosave(unsigned long pfn)
|
|
{
|
|
unsigned long nosave_begin_pfn = sym_to_pfn(&__nosave_begin);
|
|
unsigned long nosave_end_pfn = sym_to_pfn(&__nosave_end - 1);
|
|
|
|
return ((pfn >= nosave_begin_pfn) && (pfn <= nosave_end_pfn)) ||
|
|
crash_is_nosave(pfn);
|
|
}
|
|
|
|
void notrace save_processor_state(void)
|
|
{
|
|
}
|
|
|
|
void notrace restore_processor_state(void)
|
|
{
|
|
}
|
|
|
|
int arch_hibernation_header_save(void *addr, unsigned int max_size)
|
|
{
|
|
struct arch_hibernate_hdr *hdr = addr;
|
|
|
|
if (max_size < sizeof(*hdr))
|
|
return -EOVERFLOW;
|
|
|
|
arch_hdr_invariants(&hdr->invariants);
|
|
hdr->ttbr1_el1 = __pa_symbol(swapper_pg_dir);
|
|
hdr->reenter_kernel = _cpu_resume;
|
|
|
|
/* We can't use __hyp_get_vectors() because kvm may still be loaded */
|
|
if (el2_reset_needed())
|
|
hdr->__hyp_stub_vectors = __pa_symbol(__hyp_stub_vectors);
|
|
else
|
|
hdr->__hyp_stub_vectors = 0;
|
|
|
|
/* Save the mpidr of the cpu we called cpu_suspend() on... */
|
|
if (sleep_cpu < 0) {
|
|
pr_err("Failing to hibernate on an unknown CPU.\n");
|
|
return -ENODEV;
|
|
}
|
|
hdr->sleep_cpu_mpidr = cpu_logical_map(sleep_cpu);
|
|
pr_info("Hibernating on CPU %d [mpidr:0x%llx]\n", sleep_cpu,
|
|
hdr->sleep_cpu_mpidr);
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL(arch_hibernation_header_save);
|
|
|
|
int arch_hibernation_header_restore(void *addr)
|
|
{
|
|
int ret;
|
|
struct arch_hibernate_hdr_invariants invariants;
|
|
struct arch_hibernate_hdr *hdr = addr;
|
|
|
|
arch_hdr_invariants(&invariants);
|
|
if (memcmp(&hdr->invariants, &invariants, sizeof(invariants))) {
|
|
pr_crit("Hibernate image not generated by this kernel!\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
sleep_cpu = get_logical_index(hdr->sleep_cpu_mpidr);
|
|
pr_info("Hibernated on CPU %d [mpidr:0x%llx]\n", sleep_cpu,
|
|
hdr->sleep_cpu_mpidr);
|
|
if (sleep_cpu < 0) {
|
|
pr_crit("Hibernated on a CPU not known to this kernel!\n");
|
|
sleep_cpu = -EINVAL;
|
|
return -EINVAL;
|
|
}
|
|
|
|
ret = bringup_hibernate_cpu(sleep_cpu);
|
|
if (ret) {
|
|
sleep_cpu = -EINVAL;
|
|
return ret;
|
|
}
|
|
|
|
resume_hdr = *hdr;
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL(arch_hibernation_header_restore);
|
|
|
|
static void *hibernate_page_alloc(void *arg)
|
|
{
|
|
return (void *)get_safe_page((__force gfp_t)(unsigned long)arg);
|
|
}
|
|
|
|
/*
|
|
* Copies length bytes, starting at src_start into an new page,
|
|
* perform cache maintenance, then maps it at the specified address low
|
|
* address as executable.
|
|
*
|
|
* This is used by hibernate to copy the code it needs to execute when
|
|
* overwriting the kernel text. This function generates a new set of page
|
|
* tables, which it loads into ttbr0.
|
|
*
|
|
* Length is provided as we probably only want 4K of data, even on a 64K
|
|
* page system.
|
|
*/
|
|
static int create_safe_exec_page(void *src_start, size_t length,
|
|
phys_addr_t *phys_dst_addr)
|
|
{
|
|
struct trans_pgd_info trans_info = {
|
|
.trans_alloc_page = hibernate_page_alloc,
|
|
.trans_alloc_arg = (__force void *)GFP_ATOMIC,
|
|
};
|
|
|
|
void *page = (void *)get_safe_page(GFP_ATOMIC);
|
|
phys_addr_t trans_ttbr0;
|
|
unsigned long t0sz;
|
|
int rc;
|
|
|
|
if (!page)
|
|
return -ENOMEM;
|
|
|
|
memcpy(page, src_start, length);
|
|
caches_clean_inval_pou((unsigned long)page, (unsigned long)page + length);
|
|
rc = trans_pgd_idmap_page(&trans_info, &trans_ttbr0, &t0sz, page);
|
|
if (rc)
|
|
return rc;
|
|
|
|
cpu_install_ttbr0(trans_ttbr0, t0sz);
|
|
*phys_dst_addr = virt_to_phys(page);
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_ARM64_MTE
|
|
|
|
static DEFINE_XARRAY(mte_pages);
|
|
|
|
static int save_tags(struct page *page, unsigned long pfn)
|
|
{
|
|
void *tag_storage, *ret;
|
|
|
|
tag_storage = mte_allocate_tag_storage();
|
|
if (!tag_storage)
|
|
return -ENOMEM;
|
|
|
|
mte_save_page_tags(page_address(page), tag_storage);
|
|
|
|
ret = xa_store(&mte_pages, pfn, tag_storage, GFP_KERNEL);
|
|
if (WARN(xa_is_err(ret), "Failed to store MTE tags")) {
|
|
mte_free_tag_storage(tag_storage);
|
|
return xa_err(ret);
|
|
} else if (WARN(ret, "swsusp: %s: Duplicate entry", __func__)) {
|
|
mte_free_tag_storage(ret);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void swsusp_mte_free_storage(void)
|
|
{
|
|
XA_STATE(xa_state, &mte_pages, 0);
|
|
void *tags;
|
|
|
|
xa_lock(&mte_pages);
|
|
xas_for_each(&xa_state, tags, ULONG_MAX) {
|
|
mte_free_tag_storage(tags);
|
|
}
|
|
xa_unlock(&mte_pages);
|
|
|
|
xa_destroy(&mte_pages);
|
|
}
|
|
|
|
static int swsusp_mte_save_tags(void)
|
|
{
|
|
struct zone *zone;
|
|
unsigned long pfn, max_zone_pfn;
|
|
int ret = 0;
|
|
int n = 0;
|
|
|
|
if (!system_supports_mte())
|
|
return 0;
|
|
|
|
for_each_populated_zone(zone) {
|
|
max_zone_pfn = zone_end_pfn(zone);
|
|
for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++) {
|
|
struct page *page = pfn_to_online_page(pfn);
|
|
struct folio *folio;
|
|
|
|
if (!page)
|
|
continue;
|
|
folio = page_folio(page);
|
|
|
|
if (folio_test_hugetlb(folio) &&
|
|
!folio_test_hugetlb_mte_tagged(folio))
|
|
continue;
|
|
|
|
if (!page_mte_tagged(page))
|
|
continue;
|
|
|
|
ret = save_tags(page, pfn);
|
|
if (ret) {
|
|
swsusp_mte_free_storage();
|
|
goto out;
|
|
}
|
|
|
|
n++;
|
|
}
|
|
}
|
|
pr_info("Saved %d MTE pages\n", n);
|
|
|
|
out:
|
|
return ret;
|
|
}
|
|
|
|
static void swsusp_mte_restore_tags(void)
|
|
{
|
|
XA_STATE(xa_state, &mte_pages, 0);
|
|
int n = 0;
|
|
void *tags;
|
|
|
|
xa_lock(&mte_pages);
|
|
xas_for_each(&xa_state, tags, ULONG_MAX) {
|
|
unsigned long pfn = xa_state.xa_index;
|
|
struct page *page = pfn_to_online_page(pfn);
|
|
|
|
mte_restore_page_tags(page_address(page), tags);
|
|
|
|
mte_free_tag_storage(tags);
|
|
n++;
|
|
}
|
|
xa_unlock(&mte_pages);
|
|
|
|
pr_info("Restored %d MTE pages\n", n);
|
|
|
|
xa_destroy(&mte_pages);
|
|
}
|
|
|
|
#else /* CONFIG_ARM64_MTE */
|
|
|
|
static int swsusp_mte_save_tags(void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static void swsusp_mte_restore_tags(void)
|
|
{
|
|
}
|
|
|
|
#endif /* CONFIG_ARM64_MTE */
|
|
|
|
int swsusp_arch_suspend(void)
|
|
{
|
|
int ret = 0;
|
|
unsigned long flags;
|
|
struct sleep_stack_data state;
|
|
|
|
if (cpus_are_stuck_in_kernel()) {
|
|
pr_err("Can't hibernate: no mechanism to offline secondary CPUs.\n");
|
|
return -EBUSY;
|
|
}
|
|
|
|
flags = local_daif_save();
|
|
|
|
if (__cpu_suspend_enter(&state)) {
|
|
/* make the crash dump kernel image visible/saveable */
|
|
crash_prepare_suspend();
|
|
|
|
ret = swsusp_mte_save_tags();
|
|
if (ret)
|
|
return ret;
|
|
|
|
sleep_cpu = smp_processor_id();
|
|
ret = swsusp_save();
|
|
} else {
|
|
/* Clean kernel core startup/idle code to PoC*/
|
|
dcache_clean_inval_poc((unsigned long)__mmuoff_data_start,
|
|
(unsigned long)__mmuoff_data_end);
|
|
dcache_clean_inval_poc((unsigned long)__idmap_text_start,
|
|
(unsigned long)__idmap_text_end);
|
|
|
|
/* Clean kvm setup code to PoC? */
|
|
if (el2_reset_needed()) {
|
|
dcache_clean_inval_poc(
|
|
(unsigned long)__hyp_idmap_text_start,
|
|
(unsigned long)__hyp_idmap_text_end);
|
|
dcache_clean_inval_poc((unsigned long)__hyp_text_start,
|
|
(unsigned long)__hyp_text_end);
|
|
}
|
|
|
|
swsusp_mte_restore_tags();
|
|
|
|
/* make the crash dump kernel image protected again */
|
|
crash_post_resume();
|
|
|
|
/*
|
|
* Tell the hibernation core that we've just restored
|
|
* the memory
|
|
*/
|
|
in_suspend = 0;
|
|
|
|
sleep_cpu = -EINVAL;
|
|
__cpu_suspend_exit();
|
|
|
|
/*
|
|
* Just in case the boot kernel did turn the SSBD
|
|
* mitigation off behind our back, let's set the state
|
|
* to what we expect it to be.
|
|
*/
|
|
spectre_v4_enable_mitigation(NULL);
|
|
}
|
|
|
|
local_daif_restore(flags);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/*
|
|
* Setup then Resume from the hibernate image using swsusp_arch_suspend_exit().
|
|
*
|
|
* Memory allocated by get_safe_page() will be dealt with by the hibernate code,
|
|
* we don't need to free it here.
|
|
*/
|
|
int __nocfi swsusp_arch_resume(void)
|
|
{
|
|
int rc;
|
|
void *zero_page;
|
|
size_t exit_size;
|
|
pgd_t *tmp_pg_dir;
|
|
phys_addr_t el2_vectors;
|
|
void __noreturn (*hibernate_exit)(phys_addr_t, phys_addr_t, void *,
|
|
void *, phys_addr_t, phys_addr_t);
|
|
struct trans_pgd_info trans_info = {
|
|
.trans_alloc_page = hibernate_page_alloc,
|
|
.trans_alloc_arg = (__force void *)GFP_ATOMIC,
|
|
};
|
|
|
|
/*
|
|
* Restoring the memory image will overwrite the ttbr1 page tables.
|
|
* Create a second copy of just the linear map, and use this when
|
|
* restoring.
|
|
*/
|
|
rc = trans_pgd_create_copy(&trans_info, &tmp_pg_dir, PAGE_OFFSET,
|
|
PAGE_END);
|
|
if (rc)
|
|
return rc;
|
|
|
|
/*
|
|
* We need a zero page that is zero before & after resume in order
|
|
* to break before make on the ttbr1 page tables.
|
|
*/
|
|
zero_page = (void *)get_safe_page(GFP_ATOMIC);
|
|
if (!zero_page) {
|
|
pr_err("Failed to allocate zero page.\n");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
if (el2_reset_needed()) {
|
|
rc = trans_pgd_copy_el2_vectors(&trans_info, &el2_vectors);
|
|
if (rc) {
|
|
pr_err("Failed to setup el2 vectors\n");
|
|
return rc;
|
|
}
|
|
}
|
|
|
|
exit_size = __hibernate_exit_text_end - __hibernate_exit_text_start;
|
|
/*
|
|
* Copy swsusp_arch_suspend_exit() to a safe page. This will generate
|
|
* a new set of ttbr0 page tables and load them.
|
|
*/
|
|
rc = create_safe_exec_page(__hibernate_exit_text_start, exit_size,
|
|
(phys_addr_t *)&hibernate_exit);
|
|
if (rc) {
|
|
pr_err("Failed to create safe executable page for hibernate_exit code.\n");
|
|
return rc;
|
|
}
|
|
|
|
/*
|
|
* KASLR will cause the el2 vectors to be in a different location in
|
|
* the resumed kernel. Load hibernate's temporary copy into el2.
|
|
*
|
|
* We can skip this step if we booted at EL1, or are running with VHE.
|
|
*/
|
|
if (el2_reset_needed())
|
|
__hyp_set_vectors(el2_vectors);
|
|
|
|
hibernate_exit(virt_to_phys(tmp_pg_dir), resume_hdr.ttbr1_el1,
|
|
resume_hdr.reenter_kernel, restore_pblist,
|
|
resume_hdr.__hyp_stub_vectors, virt_to_phys(zero_page));
|
|
|
|
return 0;
|
|
}
|
|
|
|
int hibernate_resume_nonboot_cpu_disable(void)
|
|
{
|
|
if (sleep_cpu < 0) {
|
|
pr_err("Failing to resume from hibernate on an unknown CPU.\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
return freeze_secondary_cpus(sleep_cpu);
|
|
}
|