Commit 0006c6f1 authored by Li RongQing's avatar Li RongQing Committed by Jakub Kicinski
Browse files

devlink: Fix incorrect skb socket family dumping 



The devlink_fmsg_dump_skb function was incorrectly using the socket
type (sk->sk_type) instead of the socket family (sk->sk_family)
when filling the "family" field in the fast message dump.

This patch fixes this to properly display the socket family.

Fixes: 3dbfde7f ("devlink: add devlink_fmsg_dump_skb() function")
Signed-off-by: default avatarLi RongQing <lirongqing@baidu.com>
Link: https://patch.msgid.link/20260407022730.2393-1-lirongqing@baidu.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 39897df3

net/devlink/health.c

+1 −1
Original line number Diff line number Diff line
@@ -1327,7 +1327,7 @@ void devlink_fmsg_dump_skb(struct devlink_fmsg *fmsg, const struct sk_buff *skb) 
	if (sk) {

		devlink_fmsg_pair_nest_start(fmsg, "sk");

		devlink_fmsg_obj_nest_start(fmsg);

		devlink_fmsg_put(fmsg, "family", sk->sk_type);

		devlink_fmsg_put(fmsg, "family", sk->sk_family);

		devlink_fmsg_put(fmsg, "type", sk->sk_type);

		devlink_fmsg_put(fmsg, "proto", sk->sk_protocol);

		devlink_fmsg_obj_nest_end(fmsg);