Commit 0016e870 authored by Sunil Khatri's avatar Sunil Khatri Committed by Alex Deucher
Browse files

drm/amdgpu: Clean the functions pointer set as NULL 



We dont need to set the functions to NULL which arent
needed as global structure members are by default
set to zero or NULL for pointers.

Cc: Leo Liu <leo.liu@amd.com>
Signed-off-by: default avatarSunil Khatri <sunil.khatri@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 8231e3af

drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c

+0 −4
Original line number Diff line number Diff line
@@ -603,8 +603,6 @@ static int acp_set_powergating_state(void *handle, 


static const struct amd_ip_funcs acp_ip_funcs = {

	.name = "acp_ip",

	.early_init = NULL,

	.late_init = NULL,

	.sw_init = acp_sw_init,

	.sw_fini = acp_sw_fini,

	.hw_init = acp_hw_init,
@@ -614,8 +612,6 @@ static const struct amd_ip_funcs acp_ip_funcs = { 
	.is_idle = acp_is_idle,

	.set_clockgating_state = acp_set_clockgating_state,

	.set_powergating_state = acp_set_powergating_state,

	.dump_ip_state = NULL,

	.print_ip_state = NULL,

};



const struct amdgpu_ip_block_version acp_ip_block = {

drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c

+0 −1
Original line number Diff line number Diff line
@@ -143,7 +143,6 @@ static int isp_set_powergating_state(void *handle, 
static const struct amd_ip_funcs isp_ip_funcs = {

	.name = "isp_ip",

	.early_init = isp_early_init,

	.late_init = NULL,

	.hw_init = isp_hw_init,

	.hw_fini = isp_hw_fini,

	.is_idle = isp_is_idle,

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

+0 −5
Original line number Diff line number Diff line
@@ -4095,17 +4095,12 @@ const struct attribute_group amdgpu_flash_attr_group = { 
const struct amd_ip_funcs psp_ip_funcs = {

	.name = "psp",

	.early_init = psp_early_init,

	.late_init = NULL,

	.sw_init = psp_sw_init,

	.sw_fini = psp_sw_fini,

	.hw_init = psp_hw_init,

	.hw_fini = psp_hw_fini,

	.suspend = psp_suspend,

	.resume = psp_resume,

	.is_idle = NULL,

	.check_soft_reset = NULL,

	.wait_for_idle = NULL,

	.soft_reset = NULL,

	.set_clockgating_state = psp_set_clockgating_state,

	.set_powergating_state = psp_set_powergating_state,

};

drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c

+0 −2
Original line number Diff line number Diff line
@@ -993,8 +993,6 @@ static const struct amd_ip_funcs umsch_mm_v4_0_ip_funcs = { 
	.hw_fini = umsch_mm_hw_fini,

	.suspend = umsch_mm_suspend,

	.resume = umsch_mm_resume,

	.dump_ip_state = NULL,

	.print_ip_state = NULL,

};



const struct amdgpu_ip_block_version umsch_mm_v4_0_ip_block = {

drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c

+0 −4
Original line number Diff line number Diff line
@@ -646,8 +646,6 @@ static int amdgpu_vkms_set_powergating_state(void *handle, 


static const struct amd_ip_funcs amdgpu_vkms_ip_funcs = {

	.name = "amdgpu_vkms",

	.early_init = NULL,

	.late_init = NULL,

	.sw_init = amdgpu_vkms_sw_init,

	.sw_fini = amdgpu_vkms_sw_fini,

	.hw_init = amdgpu_vkms_hw_init,
@@ -657,8 +655,6 @@ static const struct amd_ip_funcs amdgpu_vkms_ip_funcs = { 
	.is_idle = amdgpu_vkms_is_idle,

	.set_clockgating_state = amdgpu_vkms_set_clockgating_state,

	.set_powergating_state = amdgpu_vkms_set_powergating_state,

	.dump_ip_state = NULL,

	.print_ip_state = NULL,

};



const struct amdgpu_ip_block_version amdgpu_vkms_ip_block = {