Commit 002bb027 authored by Yongsoo Joo's avatar Yongsoo Joo Committed by Keith Busch
Browse files

nvme: change return type of nvme_poll_cq() to bool 



The nvme_poll_cq() function currently returns the number of CQEs
found, However, only one caller, nvme_poll(), requires a boolean
value to check whether any CQE was completed. The other callers do
not use the return value at all.

To better reflect its usage, update the return type of nvme_poll_cq()
from int to bool.

Signed-off-by: default avatarYongsoo Joo <ysjoo@kookmin.ac.kr>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent ac32057a

drivers/nvme/host/pci.c

+4 −4
Original line number Diff line number Diff line
@@ -1147,13 +1147,13 @@ static inline void nvme_update_cq_head(struct nvme_queue *nvmeq) 
	}

}



static inline int nvme_poll_cq(struct nvme_queue *nvmeq,

static inline bool nvme_poll_cq(struct nvme_queue *nvmeq,

			        struct io_comp_batch *iob)

{

	int found = 0;

	bool found = false;



	while (nvme_cqe_pending(nvmeq)) {

		found++;

		found = true;

		/*

		 * load-load control dependency between phase and the rest of

		 * the cqe requires a full read memory barrier