Commit 003be25a authored by Jason Xing's avatar Jason Xing Committed by Martin KaFai Lau
Browse files

selftests/bpf: Correct the check of join cgroup 



Use ASSERT_OK_FD to check the return value of join cgroup,
or else this test will pass even if the fd < 0. ASSERT_OK_FD
can print the error message to the console.

Suggested-by: default avatarMartin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: default avatarJason Xing <kerneljasonxing@gmail.com>
Signed-off-by: default avatarMartin KaFai Lau <martin.lau@kernel.org>
Acked-by: default avatarHou Tao <houtao1@huawei.com>
Link: https://lore.kernel.org/all/6d62bd77-6733-40c7-b240-a1aeff55566c@linux.dev/
Link: https://patch.msgid.link/20250204051154.57655-1-kerneljasonxing@gmail.com
parent 0abff462

tools/testing/selftests/bpf/prog_tests/setget_sockopt.c

+1 −1
Original line number Diff line number Diff line
@@ -202,7 +202,7 @@ static void test_nonstandard_opt(int family) 
void test_setget_sockopt(void)

{

	cg_fd = test__join_cgroup(CG_NAME);

	if (cg_fd < 0)

	if (!ASSERT_OK_FD(cg_fd, "join cgroup"))

		return;



	if (create_netns())