Unverified Commit 0064db9c authored by David Lechner's avatar David Lechner Committed by Mark Brown
Browse files

spi: axi-spi-engine: fix version format string 



The version format string in the AXI SPI Engine driver was probably
intended to print the version number in the same format as the DT
compatible string (e.g. 1.00.a). However, the version just uses
semantic versioning so formatting the patch number as a character
is not correct and would result in printing control characters for
patch numbers less than 32.

Fixes: b1353d1c ("spi: Add Analog Devices AXI SPI Engine controller support")
Signed-off-by: default avatarDavid Lechner <dlechner@baylibre.com>
Link: https://lore.kernel.org/r/20240412-axi-spi-engine-version-printf-v1-1-95e1e842c1a6@baylibre.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent fec50db7

drivers/spi/spi-axi-spi-engine.c

+1 −1
Original line number Diff line number Diff line
@@ -623,7 +623,7 @@ static int spi_engine_probe(struct platform_device *pdev) 


	version = readl(spi_engine->base + ADI_AXI_REG_VERSION);

	if (ADI_AXI_PCORE_VER_MAJOR(version) != 1) {

		dev_err(&pdev->dev, "Unsupported peripheral version %u.%u.%c\n",

		dev_err(&pdev->dev, "Unsupported peripheral version %u.%u.%u\n",

			ADI_AXI_PCORE_VER_MAJOR(version),

			ADI_AXI_PCORE_VER_MINOR(version),

			ADI_AXI_PCORE_VER_PATCH(version));