Commit 0070dc29 authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Kevin Hilman
Browse files

bus: ti-sysc: Use of_property_present() 



Use of_property_present() to test for property presence rather than
of_get_property(). This is part of a larger effort to remove callers
of of_get_property() and similar functions. of_get_property() leaks
the DT property data pointer which is a problem for dynamically
allocated nodes which may be freed.

The code was also incorrectly assigning the return value to a 'struct
property' pointer. It didn't matter as "prop" was never dereferenced.

Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Reviewed-by: default avatarRoger Quadros <rogerq@kernel.org>
Link: https://lore.kernel.org/r/20240731191312.1710417-1-robh@kernel.org


Signed-off-by: default avatarKevin Hilman <khilman@baylibre.com>
parent 8400291e

drivers/bus/ti-sysc.c

+2 −4
Original line number Diff line number Diff line
@@ -2569,14 +2569,12 @@ static const struct sysc_dts_quirk sysc_dts_quirks[] = { 
static void sysc_parse_dts_quirks(struct sysc *ddata, struct device_node *np,

				  bool is_child)

{

	const struct property *prop;

	int i, len;

	int i;



	for (i = 0; i < ARRAY_SIZE(sysc_dts_quirks); i++) {

		const char *name = sysc_dts_quirks[i].name;



		prop = of_get_property(np, name, &len);

		if (!prop)

		if (!of_property_present(np, name))

			continue;



		ddata->cfg.quirks |= sysc_dts_quirks[i].mask;