Commit 00e8d290 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

block: don't reorder requests in blk_mq_add_to_batch 



LIFO ordering for batched completions is a bit unexpected and also
defeats some merging optimizations in e.g. the XFS buffered write
code.  Now that we can easily add the request to the tail of the list
do that.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20241113152050.157179-7-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent e70c301f

include/linux/blk-mq.h

+1 −1
Original line number Diff line number Diff line
@@ -884,7 +884,7 @@ static inline bool blk_mq_add_to_batch(struct request *req, 
	else if (iob->complete != complete)

		return false;

	iob->need_ts |= blk_mq_need_time_stamp(req);

	rq_list_add_head(&iob->req_list, req);

	rq_list_add_tail(&iob->req_list, req);

	return true;

}