Commit 01aed663 authored by Svyatoslav Pankratov's avatar Svyatoslav Pankratov Committed by Herbert Xu
Browse files

crypto: qat - fix double free during reset 



There is no need to free the reset_data structure if the recovery is
unsuccessful and the reset is synchronous. The function
adf_dev_aer_schedule_reset() handles the cleanup properly. Only
asynchronous resets require such structure to be freed inside the reset
worker.

Fixes: d8cba25d ("crypto: qat - Intel(R) QAT driver framework")
Signed-off-by: default avatarSvyatoslav Pankratov <svyatoslav.pankratov@intel.com>
Signed-off-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent fdcac2dd

drivers/crypto/intel/qat/qat_common/adf_aer.c

+2 −1
Original line number Diff line number Diff line
@@ -92,6 +92,7 @@ static void adf_device_reset_worker(struct work_struct *work) 
	if (adf_dev_restart(accel_dev)) {

		/* The device hanged and we can't restart it so stop here */

		dev_err(&GET_DEV(accel_dev), "Restart device failed\n");

		if (reset_data->mode == ADF_DEV_RESET_ASYNC)

			kfree(reset_data);

		WARN(1, "QAT: device restart failed. Device is unusable\n");

		return;