Commit 01dd825d authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Bjorn Andersson
Browse files

soc: qcom: mdt_loader: simplify with cleanup.h 



Allocate the memory with scoped/cleanup.h to reduce error handling and
make the code a bit simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240703-thermal-const-v1-2-6e59e139c65d@linaro.org


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 04e60d7a

drivers/soc/qcom/mdt_loader.c

+2 −4
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ 
 * Copyright (c) 2012-2013, The Linux Foundation. All rights reserved.

 */



#include <linux/cleanup.h>

#include <linux/device.h>

#include <linux/elf.h>

#include <linux/firmware.h>
@@ -37,13 +38,12 @@ static ssize_t mdt_load_split_segment(void *ptr, const struct elf32_phdr *phdrs, 
{

	const struct elf32_phdr *phdr = &phdrs[segment];

	const struct firmware *seg_fw;

	char *seg_name;

	ssize_t ret;



	if (strlen(fw_name) < 4)

		return -EINVAL;



	seg_name = kstrdup(fw_name, GFP_KERNEL);

	char *seg_name __free(kfree) = kstrdup(fw_name, GFP_KERNEL);

	if (!seg_name)

		return -ENOMEM;
@@ -52,7 +52,6 @@ static ssize_t mdt_load_split_segment(void *ptr, const struct elf32_phdr *phdrs, 
					ptr, phdr->p_filesz);

	if (ret) {

		dev_err(dev, "error %zd loading %s\n", ret, seg_name);

		kfree(seg_name);

		return ret;

	}
@@ -64,7 +63,6 @@ static ssize_t mdt_load_split_segment(void *ptr, const struct elf32_phdr *phdrs, 
	}



	release_firmware(seg_fw);

	kfree(seg_name);



	return ret;

}