Commit 01e21597 authored by Matt Johnston's avatar Matt Johnston Committed by Jakub Kicinski
Browse files

mctp i2c: handle NULL header address 



daddr can be NULL if there is no neighbour table entry present,
in that case the tx packet should be dropped.

saddr will usually be set by MCTP core, but check for NULL in case a
packet is transmitted by a different protocol.

Fixes: f5b8abf9 ("mctp i2c: MCTP I2C binding driver")
Cc: stable@vger.kernel.org
Reported-by: default avatarDung Cao <dung@os.amperecomputing.com>
Signed-off-by: default avatarMatt Johnston <matt@codeconstruct.com.au>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241022-mctp-i2c-null-dest-v3-1-e929709956c5@codeconstruct.com.au


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 90e0569d

drivers/net/mctp/mctp-i2c.c

+3 −0
Original line number Diff line number Diff line
@@ -588,6 +588,9 @@ static int mctp_i2c_header_create(struct sk_buff *skb, struct net_device *dev, 
	if (len > MCTP_I2C_MAXMTU)

		return -EMSGSIZE;



	if (!daddr || !saddr)

		return -EINVAL;



	lldst = *((u8 *)daddr);

	llsrc = *((u8 *)saddr);