Commit 01f4fbb3 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/sh_mobile_lcdcfb: Initialize fb_ops with fbdev macros 



Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in DMA-able virtual address space. Set the
read/write, draw and mmap callbacks to the correct implementation
and avoid implicit defaults. Also select the necessary helpers in
Kconfig.

The driver uses a mixture of DMA helpers and deferred I/O. That
probably needs fixing by a driver maintainer.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default I/O-memory-based implementation to be invoked; hence
requiring the I/O helpers to be built in any case. Setting all
callbacks in all drivers explicitly will allow to make the I/O
helpers optional. This benefits systems that do not use these
functions.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231127131655.4020-14-tzimmermann@suse.de
parent 46b655ce

drivers/video/fbdev/Kconfig

+2 −5
Original line number Diff line number Diff line
@@ -1634,12 +1634,9 @@ config FB_SH_MOBILE_LCDC 
	depends on FB && HAVE_CLK && HAS_IOMEM

	depends on SUPERH || ARCH_RENESAS || COMPILE_TEST

	depends on FB_DEVICE

	select FB_SYS_FILLRECT

	select FB_SYS_COPYAREA

	select FB_SYS_IMAGEBLIT

	select FB_SYS_FOPS

	select FB_DEFERRED_IO

	select FB_BACKLIGHT

	select FB_DEFERRED_IO

	select FB_DMAMEM_HELPERS

	help

	  Frame buffer driver for the on-chip SH-Mobile LCD controller.

drivers/video/fbdev/sh_mobile_lcdcfb.c

+3 −7
Original line number Diff line number Diff line
@@ -1488,13 +1488,10 @@ sh_mobile_lcdc_overlay_mmap(struct fb_info *info, struct vm_area_struct *vma) 


static const struct fb_ops sh_mobile_lcdc_overlay_ops = {

	.owner          = THIS_MODULE,

	.fb_read        = fb_sys_read,

	.fb_write       = fb_sys_write,

	.fb_fillrect	= sys_fillrect,

	.fb_copyarea	= sys_copyarea,

	.fb_imageblit	= sys_imageblit,

	__FB_DEFAULT_DMAMEM_OPS_RDWR,

	.fb_blank	= sh_mobile_lcdc_overlay_blank,

	.fb_pan_display = sh_mobile_lcdc_overlay_pan,

	__FB_DEFAULT_DMAMEM_OPS_DRAW,

	.fb_ioctl       = sh_mobile_lcdc_overlay_ioctl,

	.fb_check_var	= sh_mobile_lcdc_overlay_check_var,

	.fb_set_par	= sh_mobile_lcdc_overlay_set_par,
@@ -1966,8 +1963,7 @@ sh_mobile_lcdc_mmap(struct fb_info *info, struct vm_area_struct *vma) 
static const struct fb_ops sh_mobile_lcdc_ops = {

	.owner          = THIS_MODULE,

	.fb_setcolreg	= sh_mobile_lcdc_setcolreg,

	.fb_read        = fb_sys_read,

	.fb_write       = fb_sys_write,

	__FB_DEFAULT_DMAMEM_OPS_RDWR,

	.fb_fillrect	= sh_mobile_lcdc_fillrect,

	.fb_copyarea	= sh_mobile_lcdc_copyarea,

	.fb_imageblit	= sh_mobile_lcdc_imageblit,