Unverified Commit 01fd7cf3 authored by Hans de Goede's avatar Hans de Goede Committed by Ilpo Järvinen
Browse files

platform/x86: x86-android-tablets: Stop using EPROBE_DEFER 



Since the x86-android-tablets code uses platform_create_bundle() it cannot
use EPROBE_DEFER and the driver-core will translate EPROBE_DEFER to ENXIO.

Stop using EPROBE_DEFER instead log an error and return ENODEV, or for
non-fatal cases log a warning and return 0.

Reviewed-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Signed-off-by: default avatarHans de Goede <hansg@kernel.org>
Link: https://patch.msgid.link/20250920200713.20193-21-hansg@kernel.org


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 83fdf93f

drivers/platform/x86/x86-android-tablets/core.c

+4 −2
Original line number Diff line number Diff line
@@ -276,8 +276,10 @@ get_serdev_controller_by_pci_parent(const struct x86_serdev_info *info) 
	struct pci_dev *pdev;



	pdev = pci_get_domain_bus_and_slot(0, 0, info->ctrl.pci.devfn);

	if (!pdev)

		return ERR_PTR(-EPROBE_DEFER);

	if (!pdev) {

		pr_err("error could not get PCI serdev at devfn 0x%02x\n", info->ctrl.pci.devfn);

		return ERR_PTR(-ENODEV);

	}



	/* This puts our reference on pdev and returns a ref on the ctrl */

	return get_serdev_controller_from_parent(&pdev->dev, 0, info->ctrl_devname);

drivers/platform/x86/x86-android-tablets/other.c

+4 −2
Original line number Diff line number Diff line
@@ -711,8 +711,10 @@ static int __init vexia_edu_atla10_9v_init(struct device *dev) 


	/* Reprobe the SDIO controller to enumerate the now enabled Wifi module */

	pdev = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(0x11, 0));

	if (!pdev)

		return -EPROBE_DEFER;

	if (!pdev) {

		pr_warn("Could not get PCI SDIO at devfn 0x%02x\n", PCI_DEVFN(0x11, 0));

		return 0;

	}



	ret = device_reprobe(&pdev->dev);

	if (ret)