Commit 02129e62 authored by Akinobu Mita's avatar Akinobu Mita Committed by Andrew Morton
Browse files

mm/damon/vaddr: fix missing pte_unmap_unlock in damos_va_migrate_pmd_entry() 

If the PTE page table lock is acquired by pte_offset_map_lock(), the lock
must be released via pte_unmap_unlock().

However, in damos_va_migrate_pmd_entry(), if damos_va_filter_out() returns
true, it immediately returns without releasing the lock.

This fixes the issue by not stopping page table traversal when
damos_va_filter_out() returns true and ensuring that the lock is released.

Link: https://lkml.kernel.org/r/20251209151034.77221-1-akinobu.mita@gmail.com


Fixes: 09efc56a ("mm/damon/vaddr: consistently use only pmd_entry for damos_migrate")
Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Reviewed-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 612b595e

mm/damon/vaddr.c

+1 −1
Original line number Diff line number Diff line
@@ -743,7 +743,7 @@ static int damos_va_migrate_pmd_entry(pmd_t *pmd, unsigned long addr, 
		if (!folio)

			continue;

		if (damos_va_filter_out(s, folio, walk->vma, addr, pte, NULL))

			return 0;

			continue;

		damos_va_migrate_dests_add(folio, walk->vma, addr, dests,

				migration_lists);

		nr = folio_nr_pages(folio);