Commit 0227af35 authored by Akhilesh Patil's avatar Akhilesh Patil Committed by Jens Axboe
Browse files

selftests: ublk: Use ARRAY_SIZE() macro to improve code 



Use ARRAY_SIZE() macro while calculating size of an array to improve
code readability and reduce potential sizing errors.
Implement this suggestion given by spatch tool by running
coccinelle script - scripts/coccinelle/misc/array_size.cocci
Follow ARRAY_SIZE() macro usage pattern in ublk.c introduced by,
commit ec120093 ("selftests: ublk: fix ublk_find_tgt()")
wherever appropriate to maintain consistency.

Signed-off-by: default avatarAkhilesh Patil <akhilesh@ee.iitb.ac.in>
Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/aKGihYui6/Pcijbk@bhairav-test.ee.iitb.ac.in


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 8f5845e0

tools/testing/selftests/ublk/kublk.c

+2 −2
Original line number Diff line number Diff line
@@ -1400,7 +1400,7 @@ static int cmd_dev_get_features(void) 


			if (!((1ULL << i)  & features))

				continue;

			if (i < sizeof(feat_map) / sizeof(feat_map[0]))

			if (i < ARRAY_SIZE(feat_map))

				feat = feat_map[i];

			else

				feat = "unknown";
@@ -1477,7 +1477,7 @@ static void __cmd_create_help(char *exe, bool recovery) 
	printf("\tdefault: nr_queues=2(max 32), depth=128(max 1024), dev_id=-1(auto allocation)\n");

	printf("\tdefault: nthreads=nr_queues");



	for (i = 0; i < sizeof(tgt_ops_list) / sizeof(tgt_ops_list[0]); i++) {

	for (i = 0; i < ARRAY_SIZE(tgt_ops_list); i++) {

		const struct ublk_tgt_ops *ops = tgt_ops_list[i];



		if (ops->usage)