Commit 02471a78 authored by Fuad Tabba's avatar Fuad Tabba Committed by Marc Zyngier
Browse files

KVM: arm64: Remove redundant kern_hyp_va() in unpin_host_sve_state() 



The `sve_state` pointer in `hyp_vcpu->vcpu.arch` is initialized as a
hypervisor virtual address during vCPU initialization in
`pkvm_vcpu_init_sve()`.

`unpin_host_sve_state()` calls `kern_hyp_va()` on this address. Since
`kern_hyp_va()` is idempotent, it's not a bug. However, it is
unnecessary and potentially confusing. Remove the redundant conversion.

Signed-off-by: default avatarFuad Tabba <tabba@google.com>
Link: https://patch.msgid.link/20260213143815.1732675-5-tabba@google.com


Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
parent 7e7c2cf0

arch/arm64/kvm/hyp/nvhe/pkvm.c

+1 −1
Original line number Diff line number Diff line
@@ -392,7 +392,7 @@ static void unpin_host_sve_state(struct pkvm_hyp_vcpu *hyp_vcpu) 
	if (!vcpu_has_feature(&hyp_vcpu->vcpu, KVM_ARM_VCPU_SVE))

		return;



	sve_state = kern_hyp_va(hyp_vcpu->vcpu.arch.sve_state);

	sve_state = hyp_vcpu->vcpu.arch.sve_state;

	hyp_unpin_shared_mem(sve_state,

			     sve_state + vcpu_sve_state_size(&hyp_vcpu->vcpu));

}