Commit 028f3d01 authored by Gui-Dong Han's avatar Gui-Dong Han Committed by Georgi Djakov
Browse files

interconnect: debugfs: fix devm_kstrdup and kfree mismatch 



debugfs_write_file_str() uses standard kfree() to release old strings.
Initializing src_node and dst_node with devm_kstrdup() creates a memory
management mismatch. If a user writes to these debugfs nodes, the
devm-allocated memory is freed via kfree(), leaving a dangling pointer
in the device resource list that can lead to a double free.

Fix this by using standard kstrdup() instead. Since the interconnect
subsystem is strictly built-in and cannot be unloaded as a module, there
is no exit path requiring manual cleanup of these strings. The error
handling path is also simplified by taking advantage of the fact that
kfree(NULL) is a safe no-op.

Fixes: 8cc27f5c ("interconnect: debugfs: initialize src_node and dst_node to empty strings")
Signed-off-by: default avatarGui-Dong Han <hanguidong02@gmail.com>
Reviewed-by: default avatarKuan-Wei Chiu <visitorckw@gmail.com>
Link: https://msgid.link/20260318024815.7655-1-hanguidong02@gmail.com


Signed-off-by: default avatarGeorgi Djakov <djakov@kernel.org>
parent be0df73d

drivers/interconnect/debugfs-client.c

+6 −3
Original line number Diff line number Diff line
@@ -150,10 +150,13 @@ int icc_debugfs_client_init(struct dentry *icc_dir) 
		return ret;

	}



	src_node = devm_kstrdup(&pdev->dev, "", GFP_KERNEL);

	dst_node = devm_kstrdup(&pdev->dev, "", GFP_KERNEL);

	if (!src_node || !dst_node)

	src_node = kstrdup("", GFP_KERNEL);

	dst_node = kstrdup("", GFP_KERNEL);

	if (!src_node || !dst_node) {

		kfree(dst_node);

		kfree(src_node);

		return -ENOMEM;

	}



	client_dir = debugfs_create_dir("test_client", icc_dir);