Commit 02962ddb authored by Matthieu Baerts (NGI0)'s avatar Matthieu Baerts (NGI0) Committed by Jakub Kicinski
Browse files

tools: ynl: remove assigned but never used variable 

These variables are assigned but never used according to Ruff. They can
then be safely removed.

This is linked to Ruff error F841 [1]:

  A variable that is defined but not used is likely a mistake, and
  should be removed to avoid confusion.

Link: https://docs.astral.sh/ruff/rules/unused-variable/

 [1]
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: default avatarDonald Hunter <donald.hunter@gmail.com>
Reviewed-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Link: https://patch.msgid.link/20250909-net-next-ynl-ruff-v1-3-238c2bccdd99@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 287bc89b

tools/net/ynl/pyynl/ethtool.py

+0 −1
Original line number Diff line number Diff line
@@ -156,7 +156,6 @@ def main(): 
    global args

    args = parser.parse_args()



    script_abs_dir = os.path.dirname(os.path.abspath(sys.argv[0]))

    spec = os.path.join(spec_dir(), 'ethtool.yaml')

    schema = os.path.join(schema_dir(), 'genetlink-legacy.yaml')

tools/net/ynl/pyynl/ynl_gen_c.py

+0 −2
Original line number Diff line number Diff line
@@ -2803,8 +2803,6 @@ def print_kernel_policy_sparse_enum_validates(family, cw): 
                cw.p('/* Sparse enums validation callbacks */')

                first = False



            sign = '' if attr.type[0] == 'u' else '_signed'

            suffix = 'ULL' if attr.type[0] == 'u' else 'LL'

            cw.write_func_prot('static int', f'{c_lower(attr.enum_name)}_validate',

                               ['const struct nlattr *attr', 'struct netlink_ext_ack *extack'])

            cw.block_start()