Commit 02a3688c authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Keith Busch
Browse files

nvme-sysfs: add 'tls_keyring' attribute



Add a 'tls_keyring' attribute to display the contents of the
--keyring option from the connect string. Adding this attribute
allows us to recreate the original connect string from sysfs
settings.

Signed-off-by: default avatarHannes Reinecke <hare@kernel.org>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent f5eb7397
Loading
Loading
Loading
Loading
+14 −0
Original line number Diff line number Diff line
@@ -753,9 +753,20 @@ static ssize_t tls_configured_key_show(struct device *dev,
}
static DEVICE_ATTR_RO(tls_configured_key);

static ssize_t tls_keyring_show(struct device *dev,
		struct device_attribute *attr, char *buf)
{
	struct nvme_ctrl *ctrl = dev_get_drvdata(dev);
	struct key *keyring = ctrl->opts->keyring;

	return sysfs_emit(buf, "%s\n", keyring->description);
}
static DEVICE_ATTR_RO(tls_keyring);

static struct attribute *nvme_tls_attrs[] = {
	&dev_attr_tls_key.attr,
	&dev_attr_tls_configured_key.attr,
	&dev_attr_tls_keyring.attr,
};

static umode_t nvme_tls_attrs_are_visible(struct kobject *kobj,
@@ -773,6 +784,9 @@ static umode_t nvme_tls_attrs_are_visible(struct kobject *kobj,
	if (a == &dev_attr_tls_configured_key.attr &&
	    !ctrl->opts->tls_key)
		return 0;
	if (a == &dev_attr_tls_keyring.attr &&
	    !ctrl->opts->keyring)
		return 0;

	return a->mode;
}