Commit 02ac5335 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Greg Kroah-Hartman
Browse files

sysfs: introduce __SYSFS_FUNCTION_ALTERNATIVE() 



For the constification phase of 'struct attribute' various callback
struct members will need to exist in both const and non-const variants.
Keeping both members in a union avoids memory and CPU overhead but will
be detected and trapped by Control Flow Integrity (CFI). By deciding
between a struct and a union depending whether CFI is enabled, most
configurations can avoid this overhead. Code using these callbacks will
still need to be updated to handle both members explicitly.
In the union case the compiler will recognize that testing for one union
member is enough and optimize away the code for the other one.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://patch.msgid.link/20251029-sysfs-const-attr-prep-v5-3-ea7d745acff4@weissschuh.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 964c93b1

include/linux/sysfs.h

+6 −0
Original line number Diff line number Diff line
@@ -58,6 +58,12 @@ do { \ 
#define sysfs_attr_init(attr) do {} while (0)

#endif



#ifdef CONFIG_CFI

#define __SYSFS_FUNCTION_ALTERNATIVE(MEMBERS...) struct { MEMBERS }

#else

#define __SYSFS_FUNCTION_ALTERNATIVE(MEMBERS...) union { MEMBERS }

#endif



/**

 * struct attribute_group - data structure used to declare an attribute group.

 * @name:	Optional: Attribute group name