Commit 02accdf0 authored by Yiming Qian's avatar Yiming Qian Committed by Greg Kroah-Hartman
Browse files

staging: sm750fb: remove unnecessary volatile qualifiers 



The use of 'volatile' for memory-mapped I/O pointers is discouraged
in the Linux kernel as per
Documentation/process/volatile-considered-harmful.rst.

This patch removes the unnecessary 'volatile' qualifiers from the
lynx_accel struct members, improving code quality and maintainability.

Signed-off-by: default avatarYiming Qian <qianym1996@gmail.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20250909060130.12919-2-qianym1996@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6f19c1ef

drivers/staging/sm750fb/sm750.h

+3 −3
Original line number Diff line number Diff line
@@ -50,9 +50,9 @@ struct init_status { 


struct lynx_accel {

	/* base virtual address of DPR registers */

	volatile unsigned char __iomem *dprBase;

	unsigned char __iomem *dprBase;

	/* base virtual address of de data port */

	volatile unsigned char __iomem *dpPortBase;

	unsigned char __iomem *dpPortBase;



	/* function pointers */

	void (*de_init)(struct lynx_accel *accel);
@@ -128,7 +128,7 @@ struct lynx_cursor { 
	char __iomem *vstart;

	int offset;

	/* mmio addr of hw cursor */

	volatile char __iomem *mmio;

	char __iomem *mmio;

};



struct lynxfb_crtc {