Commit 0309fc3c authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'leds-fixes-6.19' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/leds 

Pull LED fix from Lee Jones:

 - Fix race condition leading to null pointer dereference on ThinkPad

* tag 'leds-fixes-6.19' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/leds:
  leds: led-class: Only Add LED to leds_list when it is fully ready
parents a66191c5 d1883cef

drivers/leds/led-class.c

+5 −5
Original line number Diff line number Diff line
@@ -560,11 +560,6 @@ int led_classdev_register_ext(struct device *parent, 
#ifdef CONFIG_LEDS_BRIGHTNESS_HW_CHANGED

	led_cdev->brightness_hw_changed = -1;

#endif

	/* add to the list of leds */

	down_write(&leds_list_lock);

	list_add_tail(&led_cdev->node, &leds_list);

	up_write(&leds_list_lock);



	if (!led_cdev->max_brightness)

		led_cdev->max_brightness = LED_FULL;
@@ -574,6 +569,11 @@ int led_classdev_register_ext(struct device *parent, 


	led_init_core(led_cdev);



	/* add to the list of leds */

	down_write(&leds_list_lock);

	list_add_tail(&led_cdev->node, &leds_list);

	up_write(&leds_list_lock);



#ifdef CONFIG_LEDS_TRIGGERS

	led_trigger_set_default(led_cdev);

#endif