Commit 0314cebb authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Hans de Goede
Browse files

platform/x86/amd/pmf: Fix missing error code in amd_pmf_init_smart_pc() 



On the error path, assign -ENOMEM to ret when memory allocation of
"dev->prev_data" fails.

Fixes: e7096150 ("platform/x86/amd/pmf: Fixup error handling for amd_pmf_init_smart_pc()")
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20240226144011.2100804-1-harshit.m.mogalapalli@oracle.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent aec7d25b

drivers/platform/x86/amd/pmf/tee-if.c

+3 −1
Original line number Diff line number Diff line
@@ -458,8 +458,10 @@ int amd_pmf_init_smart_pc(struct amd_pmf_dev *dev) 
	amd_pmf_hex_dump_pb(dev);



	dev->prev_data = kzalloc(sizeof(*dev->prev_data), GFP_KERNEL);

	if (!dev->prev_data)

	if (!dev->prev_data) {

		ret = -ENOMEM;

		goto error;

	}



	ret = amd_pmf_start_policy_engine(dev);

	if (ret)