Commit 0337355c authored by Michael-CY Lee's avatar Michael-CY Lee Committed by Felix Fietkau
Browse files

wifi: mt76: mt7996: remove unnecessary key->cipher check for BIP frames 



The cipher type check is redundant, and there is no need to dereference the
key struct here.

Signed-off-by: default avatarMichael-CY Lee <michael-cy.lee@mediatek.com>
Link: https://patch.msgid.link/20250311103646.43346-3-nbd@nbd.name


Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 8d38abdf

drivers/net/wireless/mediatek/mt76/mt7996/mac.c

+1 −2
Original line number Diff line number Diff line
@@ -773,8 +773,7 @@ mt7996_mac_write_txwi_80211(struct mt7996_dev *dev, __le32 *txwi, 
	    info->flags & IEEE80211_TX_CTL_USE_MINRATE)

		val |= MT_TXD1_FIXED_RATE;



	if (key && multicast && ieee80211_is_robust_mgmt_frame(skb) &&

	    key->cipher == WLAN_CIPHER_SUITE_AES_CMAC) {

	if (key && multicast && ieee80211_is_robust_mgmt_frame(skb)) {

		val |= MT_TXD1_BIP;

		txwi[3] &= ~cpu_to_le32(MT_TXD3_PROTECT_FRAME);

	}